Repository navigation
{Storage} Update live-test fixtures to StorageV2 and refresh copy recordings - #34245
Merged
Merged
Conversation
…ordings Use StorageV2 for six selected account fixtures after legacy Storage creation failed. Refresh and sanitize batch-copy and rehydration-copy recordings; validate nine focused live scenarios and offline replay. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
requested a review
from Yong Zhang (yonzhan)
October 20, 2026 05:17
microsoft-github-policy-service
Bot
added
Auto-Assign
x-engineering-agent
Bot
added this to the
November 2026 (2026-11-16)❗ Breaking change release ❗ milestone
Contributor
|
Hi YangAn-microsoft, |
Validate blob, Azure Files and SAS remove paths against live storage accounts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The batch-copy recording refresh described in the PR was not included in the supplied diff, preventing complete validation.
No open issues 🎉
What changed in this PR
Test-only maintenance supporting earlier storage security fixes, with no production behavior changes.
Changes:
- Set nine storage account fixtures to
StorageV2to avoid setup failures. - Refresh copy recordings and sanitize recorded credentials and identifiers.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/test_storage_blob_copy_scenarios.py | Updates the same-account SAS fixture. |
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/test_storage_batch_operations.py | Updates both batch-copy account fixtures. |
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/test_storage_azcopy_scenarios.py | Updates six AzCopy account fixtures. |
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/recordings/test_storage_blob_copy_rehydrate_priority.yaml | Refreshes recording metadata and redacts identity fields. |
Review effort: Balanced
ZelinWang (wangzelin007)
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
az storage copy,az storage remove,az storage blob sync,az storage blob copy start,az storage blob copy start-batch, andaz storage fs directory upload/downloadDescription
Test-maintenance follow-up to #34230, #34171, and #34138. No production-code changes.
StorageV2for nine selected storage account fixtures across the blob-copy, batch-operation, and AzCopy test files. Live runs using the legacy defaultStoragekind failed during setup withAccountKindNotSupported.test_storage_blob_batch_copy.yamlandtest_storage_blob_copy_rehydrate_priority.yamlagainst current development sources.AzCopy and ADLS scenarios inherit from
LiveScenarioTestand do not generate replay recordings. The two replayable scenarios were re-recorded with their standard resource-group preparers and replayed without development-resource overrides.Testing Guide
Validation used Python 3.13 on Windows, the
latestAPI profile, and development source revisionce030fb498a93991794067989bd2d06e0eddc404plus these test-fixture changes.Focused regressions:
Result: 77 passed, 1 skipped, 103 subtests passed. The skip is for POSIX-only symlink semantics.
Targeted live scenarios:
Result: 9 passed.
The live run used a dedicated temporary resource group with an explicitly approved
Storage Blob Data Contributorassignment for the signed-in identity, scoped only to that group, to exercise the mixed OAuth/key/SAS ADLS scenarios. The temporary role assignment and all test resource groups were confirmed deleted afterward.Additional
storage removelive coverage, using standard resource-group preparers:Result: 3 passed, covering blob removal, Azure Files removal, and supplied SAS credentials. Combined with the initial run, 12 distinct targeted live scenarios passed.
storage_fs_directory_copyis an internal handler registered forstorage fs directory uploadandstorage fs directory download, both covered by the initial live run. There is no separately exposedaz storage fs directory copycommand in this source revision.Portable recording generation and replay, without resource-group overrides:
Results: 2 passed live, then 2 passed offline after recording sanitization.
git diff --check: passed.The full storage live suite was not run. These results cover the selected paths relevant to the three merged PRs, not the entire storage module.
History Notes
None. Test-only maintenance; no customer-facing command behavior changes.