Repository navigation
Allow a poll's uploaded report PDF through the download proxy - #119
Merged
Merged
Conversation
York Factory now serves an uploaded report PDF (report_pdf_en/fr) as a poll's analysis_pdf when one is attached, in place of the generated report and the crosstab Excel/JSON. The proxy only forwards known assets, so it must accept the new names. The poll page needs no change: the existing "Download Report (PDF)" link points at whichever file York Factory names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
report_pdf_en/report_pdf_frto the poll download proxy's allowed assets.analysis_pdfwhen one is attached, in place of the generated report and the crosstab Excel/JSON. The proxy only forwards known asset names, so without this the "Download Report (PDF)" link would 404.crosstabs_pdf_en/fr(and its label and type), which York Factory no longer has.PollDetailsalready renders "Download Report (PDF)" fromdownloads.analysis_pdf, and hides the crosstab links when York Factory omits them.Testing
npm run test:polls: 15 pass, including a new test that areport_pdf_enURL maps through the proxy as the report download.Merge with or after BuildCanada/york_factory#146.
🤖 Generated with Claude Code