Feat: added deb822 support for Debian 12,13, Ubuntu 24 support onward - #1699
Open
watysay wants to merge 1 commit into
Open
Feat: added deb822 support for Debian 12,13, Ubuntu 24 support onward#1699watysay wants to merge 1 commit into
watysay wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1636
PKGS-7388 issue on detecting security repository for APT.
Added deb822 format support in APT sources list.
Used on Debian 12,13, Ubuntu 24 and onward.
Now search for "^Types: deb" in /etc/apt/sources.list.d/.sources. It's the declaration model for deb packages repository, so should be present in every declaration of repo.
Could look for ".sources" files vs "*.list" files also (newer format vs older format).
Ubuntu did not change the security url ("security.ubuntu.com"), the search was still working (Ubuntu 24.04 clo
ud image).
Debian did ("security.debian.org" -> "debian-security"). Tested KO on Debian 12 and Debian 13.
Log before change (failing on Debian 12):
Log after change:
Tested on Debian 12, 13 and Ubuntu 24.04 all cloud images.
PS: This is my first PR, hope I'm doing okay. Feel free to give feedback :)