Repository navigation
Simplified data adequacy - #424
Open
jmafoster1 wants to merge 3 commits into
Open
jmafoster1 wants to merge 3 commits into
jmafoster1 wants to merge 3 commits into
Conversation
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| black | 35 | 1 | 0.89s | ||
| ✅ PYTHON | pylint | 35 | 0 | 5.44s |
See detailed report in MegaLinter reports
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
+ Coverage 97.94% 97.95% +0.01%
==========================================
Files 29 29
Lines 1898 1910 +12
==========================================
+ Hits 1859 1871 +12
Misses 39 39
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
jmafoster1
force-pushed
the
jmafoster1/sigmoid
branch
from
November 3, 2026 11:14
7fd5d49 to
3c494de
Compare
jmafoster1
marked this pull request as ready for review
November 3, 2026 11:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an "easy interpret" option for causal data adequacy that puts the absolute kurtosis value through a sigmoid function and converts it to a "percentage". Closes #412. Credit to @SylviaWhittle for the original idea. Hope this isn't stepping on your toes, I just thought it'd be good to get it in the paper (which I plan to write this week).
What I ended up doing was taking the absolute kurtosis value and putting that through a sigmoid such that kurtoses close to zero correspond to values close to 100 and kurtoses far from zero correspond to values close to zero. A kurtosis of -0.8 corresponds to 50, since a uniform distribution (which represents just about the worst case that it's possible to get here) has a kurtosis of -1.2. Using -0.8 roughly corresponds to a distribution that's visually "about half way" between a uniform distribution and the normal distribution that gives a perfect value (the scale is not linear).
Main file changes
causal_testing/testing/data_adequacy.py - added a
simplified_kurtosisfunction.I also added the option to flip between raw and simplified values in the dashboard (with simplified being the default) and added explanations in there.
The other changes are tests and docs.
Checklist
Before you mark your PR as ready for review, please ensure you have completed the following.
docs/and checked for updated configuration/runtime optionsdocs/source/tutorialsfor any new functionalitysphinx-build -W source/ build