Repository navigation
Conversation
caquick.site가 2026-11-29 만료돼 caquick.com으로 옮긴다. 전환 전 준비로 새 오리진을 옛 도메인과 병행 허용만 하고, 운영 주소 전환은 FE와 같은 시간대에 APP_ENV로 한다. - CORS 운영 목록: caquick.com·admin.caquick.com 추가 - returnTo 허용 목록: caquick.com 추가 - S3 CORS(terraform) 같은 두 오리진 추가 - app.env.example·README 운영 주소 .com - 회귀 테스트 3건(CORS 2·returnTo 1)
feat: caquick.com 도메인 허용(CORS·로그인 returnTo·S3 CORS)
접두 비교라 caquick.site.evil.com·caquick.site@evil.com 같은 주소가 통과해 로그인 뒤 외부로 보낼 수 있었다. URL로 파싱해 http(s)이고 오리진이 허용 목록과 같을 때만 그 주소를 쓴다. - return-to.helper.ts 추가, OidcLoginService.normalizeReturnTo가 사용 - 회귀 테스트 15건(it.each 표: 허용 3·거부 11·기본 주소 오리진 1)
fix: 로그인 returnTo를 오리진 정확 일치로 검사
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
도메인 URL과 운영 오리진 설정 README.md, README.en.md, infra/app.env.example, src/config/cors-origins.ts, src/config/cors-origins.spec.ts, terraform/aws.tf |
문서와 환경 예시의 URL을 caquick.com 주소로 변경했습니다. 운영 CORS 오리진과 미디어 버킷 CORS 오리진에 새 도메인을 추가했습니다. 기존 caquick.site 운영 오리진은 유지합니다. |
OIDC 반환 URL 검증 src/features/auth/constants/auth.constants.ts, src/features/auth/helpers/return-to.helper.ts, src/features/auth/helpers/return-to.helper.spec.ts, src/features/auth/services/oidc-login.service.ts, src/features/auth/services/oidc-login.service.spec.ts |
resolveReturnTo가 HTTP(S) 주소의 오리진을 fallback 또는 허용 목록과 비교합니다. OIDC 로그인 서비스가 반환 URL 처리를 이 함수에 위임하며, 테스트는 주소 검증과 반환 URL 쿠키 기록을 확인합니다. |
Estimated code review effort: 3 (Moderate) | ~20 minutes
Merge Risk: 
2fb53
-
No merge-blocking issue is established. A .com frontend using the .site API would need cross-site cookie handling.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Title check 제목은 caquick.com 도메인 허용과 returnTo 오리진 검사 변경을 간결하게 설명하며, 변경 내용과 직접 관련됩니다. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 7 files. (4 skipped: 4 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🧹 knip — dead-code 리포트전체 리포트
|
🩺 NestJS Doctor — 90/100 (Excellent)진단 493건 (error 13).
architecture / security 상위 항목
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success4333 tests passing in 389 suites. Report generated by 🧪jest coverage report action from 2fb5317 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
caquick.site(2026-11-29 만료)에서 caquick.com으로 옮기기 위한 BE 준비를 운영에 반영합니다. 새 도메인을 옛 도메인과 나란히 허용만 하므로, 이 릴리즈만으로 바뀌는 동작은 없습니다.
https://caquick.com·https://admin.caquick.com추가(.site는 만료까지 병행)https://caquick.com추가https://caquick.site.evil.com·https://caquick.site@evil.com같은 주소가 통과하던 오픈 리다이렉트를 막습니다.운영 반영 사항입니다.
APP_ENV의BACKEND_BASE_URL·FRONTEND_BASE_URL) 전환은 FE 전환과 같은 시간대에 따로 진행합니다.Summary by CodeRabbit
caquick.com도메인으로 변경되었습니다. 기존caquick.site주소도 운영 허용 목록에 유지됩니다.