[HOLD — deploy-gated] GitHub in-app OAuth + Universal Links (iOS A1/A2) - #14
Open
Adron wants to merge 1 commit into
Open
[HOLD — deploy-gated] GitHub in-app OAuth + Universal Links (iOS A1/A2)#14Adron wants to merge 1 commit into
Adron wants to merge 1 commit into
Conversation
…nt (A1/A2 iOS) A1: OAuthProvider.supportsNativeAuth now returns true for all providers (was 'self != .github'), so GitHub sign-in + linking enable in LoginView/RegisterView/ LinkedIdentitiesView. A2: add com.apple.developer.associated-domains (applinks:interlinedlist.com) to the entitlements; G10's onOpenURL/AppDeepLink.parse already route https permalinks. DEPLOY-GATED — see PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adron
added a commit
that referenced
this pull request
Aug 3, 2026
Hand-off spec for the two remaining backend/ops dependencies for iOS parity: exact backend diffs (GitHub authorize/callback mobile handoff; AASA route + middleware bypass), the AASA JSON with appID BJA9558E4B.com.interlinedlist.app, the iOS entitlement/flag, and the deploy + Apple-portal provisioning steps. Implementations: backend PR (CompositeCode/interlinedlist) + iOS HOLD PR #14. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS side of backend asks A1 (GitHub in-app OAuth) + A2 (Universal Links)
Pairs with the backend PR (
feat(auth): GitHub mobile OAuth handoff + Universal Links AASA) onCompositeCode/interlinedlist. Details inBackend-Asks-A1-A2.md.Changes (3 files)
OAuthCoordinator.supportsNativeAuthnow returnstruefor all providers (wasself != .github). GitHub sign-in and linking light up automatically inLoginView/RegisterView/LinkedIdentitiesView.com.apple.developer.associated-domains=applinks:interlinedlist.comtoInterlinedList.entitlements(alongsideaps-environment). No app code change — G10's.onOpenURL+AppDeepLink.parsealready routehttps://interlinedlist.com/{user,message,lists,documents}/…permalinks. (Also refreshed the staleTODO(A2)note inInterlinedListApp.swift.)Merge prerequisites (ops — cannot be done in code)
/api/auth/github/{authorize,callback}ships the mobile sync-token handoff, tapping GitHub 401s (routes through the existinghandleUnauthorized()path, but it's a dead button).com.interlinedlist.appin the Apple Developer portal and regenerate the provisioning profile. Without it, signed device/TestFlight/App-Store builds fail to sign with the new entitlement. (Simulator builds and the code-signing-disabled CI build are unaffected — verified:build-for-testinggreen, 747 unit tests pass.)After both, deploy the backend AASA and verify via
https://app-site-association.cdn-apple.com/a/v1/interlinedlist.com, then merge.🤖 Generated with Claude Code