Repository navigation
Fixed lint-staged hook to only check staged files - #1824
Merged
Merged
Conversation
The Prettier and ESLint lint-staged commands invoked package.json scripts that already target the whole repository (`prettier --write .`) or the whole `js/` directory, so every commit reformatted and linted unrelated files. Call the tools directly so lint-staged passes only staged files. Also added pnpm-lock.yaml to .prettierignore and removed a trailing space in style/app.scss. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage Report for CI Build 41323639772Coverage remained the same at 60.654%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The lint-staged pre-commit hook was formatting and linting far more than the files in each commit:
"*": "pnpm prettier --ignore-unknown --write"ran theprettierpackage script (prettier --write .), so every commit ran Prettier over the whole repository. Unrelated files (e.g.pnpm-lock.yaml) were left modified in the working tree after committing."*.{js,ts,tsx}": "pnpm run eslint --cache --fix js"ran theeslintscript (eslint --fix js) with anotherjsargument, so it linted the wholejs/directory.Changes:
prettier,eslintandstylelintdirectly, so lint-staged passes only the staged files. Thestylelintentries already behaved correctly and were changed for consistency. Thehlint/fourmoluentries are unchanged.pnpm-lock.yamlto.prettierignore, since the lockfile is generated by pnpm and shouldn't be reformatted.style/app.scss, which the previous whole-repository Prettier run had picked up.Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
How this was verified (no automated tests apply to hook configuration):
pnpm exec lint-stagedwith one badly formatted staged JS file and one badly formatted unstaged JS file. Only the staged file was formatted and linted.prettier --file-info pnpm-lock.yamlreports"ignored": true.🤖 Generated with Claude Code