Skip to content

Drop Unused sympy Import - #792

Merged
MattToast merged 3 commits into
CrayLabs:developfrom
MattToast:drop-sympy
Dec 19, 2025
Merged

Drop Unused sympy Import#792
MattToast merged 3 commits into
CrayLabs:developfrom
MattToast:drop-sympy

Conversation

@MattToast

@MattToast MattToast commented Dec 17, 2025

Copy link
Copy Markdown
Member

Looks like this import was added to this test file and is not used. Dropping because it's not listed in the test requirements, does not look like its used, and was causing me some problems when attempting to run tests locally.

@MattToast
MattToast requested a review from al-rigazzi December 17, 2025 02:17
@MattToast MattToast self-assigned this Dec 17, 2025
@MattToast MattToast added the area: test Issues related to the test suite label Dec 17, 2025
@codecov

codecov Bot commented Dec 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.20%. Comparing base (d7d979e) to head (c810705).
⚠️ Report is 23 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #792      +/-   ##
===========================================
- Coverage    83.91%   80.20%   -3.72%     
===========================================
  Files           83       78       -5     
  Lines         6284     6081     -203     
===========================================
- Hits          5273     4877     -396     
- Misses        1011     1204     +193     

see 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@al-rigazzi al-rigazzi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, LGTM pending changelog update!

@al-rigazzi

Copy link
Copy Markdown
Collaborator

The macos-13 actions are deprecated, you should be able to merge the current develop into your branch and they'll go away.

@MattToast
MattToast merged commit fb0ea1f into CrayLabs:develop Dec 19, 2025
72 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: test Issues related to the test suite ignore-for-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants