Repository navigation
Add focus mode and script renaming to the scripting terminal - #89
Merged
rubensworks merged 5 commits intoOct 19, 2026
Merged
Conversation
Coverage Report for CI Build 39294249802Coverage decreased (-2.5%) to 42.542%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions408 previously-covered lines in 9 files lost coverage. Coverage Stats
💛 - Coveralls |
Paths in the script list are truncated, so files with a common prefix, such as inventory_sorting_main.js and inventory_sorting_test.js, or files in subdirectories could not be told apart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
New scripts were always named script0.js, script1.js and so on, and could only be renamed or moved into directories through the file system, which players on a server can't access. Right-click a script to rename it, which also allows moving it into a directory or changing its language through its extension. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
The editor only uses a small part of the screen, showing about a dozen wrapped lines. Add a toolbar button to show only the editor, using most of the screen, with the toolbar moving along above it. Escape or the button returns to the normal terminal. See #44 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
rubensworks
force-pushed
the
terminal-ux-clean/5-highlighting-performance
branch
from
October 18, 2026 18:07
a7c8067 to
f105ac8
Compare
rubensworks
force-pushed
the
terminal-ux-clean/6-layout-and-files
branch
from
October 18, 2026 18:07
917f9c9 to
bfc3760
Compare
Base automatically changed from
terminal-ux-clean/5-highlighting-performance
to
master-1.21-lts
October 19, 2026 17:05
Variable cards refer to scripts by path, so they stop working when their script is renamed. The rename dialog now says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
The enlarged editor could only be toggled with its button. F12 now toggles it too, as F11 is used by Minecraft for fullscreen, and keeps the editor focused so typing can continue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #82, with the same changes and a clean commit history: every commit is one standalone change. Phase 6, the last of the scripting terminal UX stack.
I checked each problem in a dev client driven by clientdevbridge before fixing it, then checked it again with this branch.
inventory_sorting_main.jsandinventory_sorting_test.jsboth showed asinventory_sorting..., andlib/helpers/math_utils.jswas cut off.scriptN.js, and could only be renamed or moved through the file system, which players on a server can't reach.util/a/new.jsmoves it into folders, and changing the extension changes its language. The open script stays open with its undo history. Checked in-game: renames into new folders keep content on disk; renaming onto an existing name is refused;../escape.jsis rejected by the server, which then corrects the client, and nothing is written outside the disk folder. Includes a unit test that a file watcher reload doesn't undo a rename that isn't flushed to disk yet, and a line in the info book's shortcuts section.…. The info book's shortcuts section mentions Escape.A fix for a resize data-loss bug I found while working on this (the editor came back empty after a window resize, and the next keystroke overwrote the script) went into #77, which is merged.
Dropped from the original plan
.stdout/.stderrlog files: they already open as readable text in the terminal, and I found no actual problem with how they're shown today.Testing
./gradlew buildpasses, including the new unit test../gradlew runGameTestServer: all 23 tests pass.Generated by Claude Code