Repository navigation
Open new scripts after creating them in the terminal - #97
Merged
Merged
Conversation
Coverage Report for CI Build 39298394831Warning No base build found for commit Coverage: 42.353%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
rubensworks
commented
Oct 19, 2026
Creating a script with the + button left the previous script open, so the new one had to be selected manually. It is now opened and focused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
rubensworks
force-pushed
the
fix/open-new-script
branch
from
October 19, 2026 17:01
5ebdcce to
bcb3259
Compare
…ew-script # Conflicts: # src/main/java/org/cyclops/integratedscripting/inventory/container/ContainerTerminalScripting.java
Member
Author
|
The red check isn't from this PR's code. In "Build for Java 23 on temurin", the build, unit tests and all 24 game tests pass. The job then fails in the Coveralls coverage-reporter install step: the downloaded Generated by Claude Code |
…ew-script # Conflicts: # src/main/java/org/cyclops/integratedscripting/client/gui/container/ContainerScreenTerminalScripting.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the
+button createdscriptN.jsbut kept the previous script open, so you had to click the new one before typing.Now, when the client receives a script,
TerminalScriptingModifiedScriptPacketfirst checks whether that path already existed, and passes acreatedflag to the terminal's remote change listener. After clicking+, the terminal opens and focuses the first script created on that disk, so you can start typing right away. Changes to existing scripts in the meantime are ignored, for example external edits orconsole.logoutput.Validation:
+opensscript1.jsand typed text goes straight into it. A second+while another script was edited externally opened the newscript2.js.buildandrunGameTestServer(23/23) pass.🤖 Generated with Claude Code
https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9