Repository navigation
Scripting terminal: error tooltip, scrollbar and JEI polish - #98
Merged
Merged
Conversation
Coverage Report for CI Build 39290546111Coverage decreased (-0.6%) to 44.113%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions575 previously-covered lines in 4 files lost coverage. Coverage Stats
💛 - Coveralls |
The tooltip of a syntax error was placed at the mouse, often covering the line it describes. Like in other editors, it is now placed below all rows of the line, or above them if there is no room, with an arrow pointing at the column of the error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
The scrollbar took as much width as an inventory scrollbar, leaving less room for text in the small editor. It is now about half as wide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
The red mark of a syntax error on the scrollbar was drawn over the scrollbar handle, and gave no information when hovered. It is now drawn below the handle, and hovering it shows the error message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
JEI drew its item list over the enlarged script editor. When JEI is installed, the focus mode now claims the whole screen, so JEI hides it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
JEI keeps its bookmark and config buttons in the bottom corners of the screen, which overlapped the enlarged script editor. The focus mode now leaves a larger margin when JEI is installed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
rubensworks
force-pushed
the
terminal-ux-clean/12-editor-polish
branch
from
October 19, 2026 17:01
ebf341f to
0a2a0f2
Compare
…/12-editor-polish # Conflicts: # src/main/java/org/cyclops/integratedscripting/client/gui/component/input/WidgetTextArea.java
Base automatically changed from
terminal-ux-clean/11-completion
to
master-1.21-lts
October 20, 2026 17:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #96. There are five standalone commits:
@JeiPluginregisters a container handler that claims the whole screen as an extra area while focus mode is on, so JEI hides its item list. It's only loaded when JEI is installed, and the JEI API is a compile-only dependency (jei_version=19.16.0.152, the newest that runs on our NeoForge 21.1.2).Validation:
runGameTestServerpasses 25/25 on the tip.🤖 Generated with Claude Code
https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9