Repository navigation
Fix the scripting terminal showing disk -1, and update CyclopsCore - #99
Open
rubensworks wants to merge 3 commits into
Open
rubensworks wants to merge 3 commits into
rubensworks wants to merge 3 commits into
Conversation
An empty drive added disk -1 to the network, which the scripting terminal then showed as an available disk. Replacing a disk in a drive by another one also kept the old disk in the network. Drives now only expose the disk they contain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
Coverage Report for CI Build 39476691451Coverage increased (+0.1%) to 43.876%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions251 previously-covered lines in 4 files lost coverage. Coverage Stats
💛 - Coveralls |
rubensworks
force-pushed
the
fix/no-disk
branch
2 times, most recently
from
October 20, 2026 18:49
9d11c19 to
bb4b564
Compare
The empty editor now tells the player what to do next: insert a Scripting Disk into a connected drive when there are no disks, click + to create a script when the disk is empty, or select a script from the list otherwise. The unusable editor and script list are also grayed out more clearly. The create and open-folder buttons are hidden while there are no disks, and the disk field no longer shows -1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
This includes the fix for incorrect key binding labels in info book appendices, such as the ones in the editor shortcuts section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
rubensworks
force-pushed
the
fix/no-disk
branch
from
October 20, 2026 19:08
bb4b564 to
12cd49f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are three standalone commits:
Fix empty scripting drives exposing a disk with ID -1. With an empty Scripting Drive in the network, the terminal showed "Disk: -1" with an empty script list. Two bugs caused it:
ScriptingDriveNetworkElementadded the drive's disk ID to the network even when the drive was empty (ID -1).BlockEntityScriptingDrive.setExposedDiskIdonly removed the old disk when the new ID was -1. So inserting a disk into such a drive kept the stray -1, and swapping one disk directly for another kept both in the network.Drives now only add or remove real disk IDs. The new game test
testScriptingDriveExposedDiskscovers an empty drive, inserting a disk, swapping it and removing it. It fails on master with "Expected disks [] but got [-1]". Network disks are rebuilt when the world loads, so existing worlds are fixed too.Show a hint in the scripting terminal editor when no script is open. The empty editor now shows a hint for the next step, centered in the editing area:
The unusable editor (including the line number gutter) and script list are darkened more clearly. The old overlay was barely visible because its shader color reduced the alpha to about 12%. Without disks, the disk field is empty instead of -1, and the "+" and open-folder buttons (which did nothing) are hidden.
Update to CyclopsCore 1.30.0 (
1.30.0-1205, the build of Show the bound key in key binding appendices CyclopsCore#255). It fixes the key binding labels in info book appendices. I checked the Editor Shortcuts section in-game: every binding shows its real key, includingALT + Up ArrowandF12.Validation:
buildpasses, andrunGameTestServerpasses 27/27, including the new test.🤖 Generated with Claude Code
https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9