Repository navigation
Conversation
…ne pread() on MinGW
illwieckz
force-pushed
the
illwieckz/dump_syms_mac
branch
2 times, most recently
from
October 21, 2026 11:37
f3381f5 to
10df57e
Compare
slipher
reviewed
Oct 21, 2026
| #ifndef COMMON_MAC_BYTESWAP_H_ | ||
| #define COMMON_MAC_BYTESWAP_H_ | ||
|
|
||
| #include "compat/linux.h" |
Member
There was a problem hiding this comment.
Seems strange that this is in byteswap.h. This could be moved to where pread is used or at least have a comment like 'HACK: including this here because pread is used in 10 files'.
Member
Author
There was a problem hiding this comment.
Oh, good catch! It mistakenly ended there because some previous fixed landed there, I probably wrote it in the wrong editor that was already open. And later I named the test commit from the file it modified without questioning lol.
That header was meant to be in src/common/mac/macho_walker.cc. Now fixed.
illwieckz
force-pushed
the
illwieckz/dump_syms_mac
branch
from
October 22, 2026 03:38
10df57e to
f96d8c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make macOS'
dump_syms_macbuildable and runnable on any system.configure: drop the now unused X86_HOST variableJust clean-up of the now unused
X86_HOSTvariable inconfigure.acafter its removal inMakefile.am:configure: detect macOS build machineMake possible to do macOS-specific branching in
Makefile.am.makefile: only use vendored macOS headers on non-macOS build systemsFix the build on macOS.
src/common/mac/byteswap: define byteswap symbols for MinGWHelp fixing the build on MinGW.
src/common/mac/macho_walke: add compat/linux.h compatibility to define pread() on MinGWFinish fixing the build on MinGW.
makefile: enable the building of dump_syms_mac on every systemNow every system can build and run
dump_syms_mac, verified on the CI and locally.Picked from: