Skip to content

configure,makefile: make possible to not build upload tools (requiring curl) - #50

Merged
illwieckz merged 3 commits into
masterfrom
illwieckz/curl
Oct 21, 2026
Merged

illwieckz merged 3 commits into
masterfrom
illwieckz/curl

Conversation

@illwieckz

@illwieckz illwieckz commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Make possible to disable upload tools requiring curl.

Better implementation than comments, makes possible for the CI to build them and projects like Unvanquished to explicitly use --disable-upload-tools when needed.

Also does some (previously vendored) curl leftover cleanup.

Also fixes those warnings:

Makefile.am:736: warning: variable 'src_tools_linux_symupload_minidump_upload_SOURCES' is defined but no program or
Makefile.am:736: library has 'src_tools_linux_symupload_minidump_upload' as canonical name (possible typo)
Makefile.am:742: warning: variable 'src_tools_linux_symupload_sym_upload_SOURCES' is defined but no program or
Makefile.am:742: library has 'src_tools_linux_symupload_sym_upload' as canonical name (possible typo)
Makefile.am:740: warning: variable 'src_tools_linux_symupload_minidump_upload_LDADD' is defined but no program or
Makefile.am:740: library has 'src_tools_linux_symupload_minidump_upload' as canonical name (possible typo)
Makefile.am:753: warning: variable 'src_tools_linux_symupload_sym_upload_LDADD' is defined but no program or
Makefile.am:753: library has 'src_tools_linux_symupload_sym_upload' as canonical name (possible typo)

Picked from:

@illwieckz

Copy link
Copy Markdown
Member Author

Hmm, I think I will rename the option --disable-curl-tools.

@illwieckz illwieckz changed the title configure,makefile: make possible to disable curl and not build tools and checks requiring it configure,makefile: make possible to not build upload tools (reequiring curl) Oct 20, 2026
@illwieckz

Copy link
Copy Markdown
Member Author

Hmm, I think I will rename the option --disable-curl-tools.

Finally renamed --disable-upload-tools.

@illwieckz illwieckz changed the title configure,makefile: make possible to not build upload tools (reequiring curl) configure,makefile: make possible to not build upload tools (requiring curl) Oct 20, 2026
@slipher

slipher commented Oct 21, 2026

Copy link
Copy Markdown
Member

LGTM, thanks for fixing that

@illwieckz
illwieckz merged commit 366ece9 into master Oct 21, 2026
@illwieckz
illwieckz deleted the illwieckz/curl branch October 21, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants