Repository navigation
chore: add e2e cdk lambda fixture - #626
Merged
Merged
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 26, 2026
ava-silver
marked this pull request as ready for review
June 26, 2026 21:54
ava-silver
force-pushed
the
ava.silver/chore/add-e2e-cdk-lambda-fixture
branch
from
June 29, 2026 17:34
f0c6f88 to
95acad5
Compare
Base automatically changed from
ava.silver/chore/add-synced-e2e-shared-helpers
to
main
June 29, 2026 18:20
ava-silver
force-pushed
the
ava.silver/chore/add-e2e-cdk-lambda-fixture
branch
from
August 6, 2026 19:06
95acad5 to
eefe03a
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-e2e-cdk-lambda-fixture
branch
from
August 17, 2026 20:59
eefe03a to
a22a825
Compare
ava-silver
force-pushed
the
ava.silver/chore/add-e2e-cdk-lambda-fixture
branch
from
November 13, 2026 22:31
a22a825 to
378f072
Compare
avangelillo
approved these changes
Nov 16, 2026
| // (E2E_INSTRUMENT=false), then again with DatadogLambda applied to the same function. REMOVE is | ||
| // `cdk destroy` of the stack. | ||
| const instrument = process.env.E2E_INSTRUMENT === "true"; | ||
| const serviceName = requireEnv("E2E_SERVICE_NAME"); |
Contributor
There was a problem hiding this comment.
Is the service name static or does it end up including something like the run ID? If it is static you may want to not name the lambda function and let CFN handling the exact naming by adding its own suffix
Collaborator
Author
There was a problem hiding this comment.
It includes the run ID -- it's one-e2e-cdk-lambda-<runId>, where the run ID is random per run, so runs don't collide. Keeping an explicit name is intentional:
- The shared sweeper finds leaked functions and log groups by the
one-e2e-prefix, so a CFN-generated name wouldn't get cleaned up. - The verifier, invoke, and cleanup checks look the function up by name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Adds the CDK app that the Lambda E2E suite (#627) deploys:
DatadogLambdawith the construct's default Node and extension layer versions.apiKeySecretso the construct grants read access to the exact ARN.one_e2e_createdandone_e2e_run_idtags, so the shared sweeper can find and delete leaked stacks.e2e/ecs-fargate/.Motivation
First half of SVLS-10087. The lifecycle test and workflow are in #627.
Testing Guidelines
Before: No Lambda workload exists for an E2E suite to deploy.
After: The E2E run on #627 deployed this app with and without the construct, verified the instrumented configuration and telemetry, and destroyed it.
Types of Changes
Check all that apply