Repository navigation
fix: publish CDK npm package with OIDC - #790
Merged
Merged
Conversation
nina9753
force-pushed
the
nina.rei/svls-10010-npm-trusted-publishing
branch
from
November 17, 2026 18:15
4bc93b2 to
96e88b7
Compare
nina9753
marked this pull request as ready for review
November 17, 2026 18:29
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ava-silver
reviewed
Nov 17, 2026
|
|
||
| At this point you're waiting on us. We may suggest some changes or improvements or alternatives. | ||
|
|
||
| ## Releasing the v2 package |
Collaborator
There was a problem hiding this comment.
this makes it sound like outside contributors can do releases, which isnt true. maybe better to just keep this in internal documentation?
nina9753
force-pushed
the
nina.rei/svls-10010-npm-trusted-publishing
branch
from
November 17, 2026 19:05
96e88b7 to
e54cf36
Compare
ava-silver
reviewed
Nov 17, 2026
joepeeples
approved these changes
Nov 17, 2026
ava-silver
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datadog-cdk-constructs-v2from a GitHub-hosted runner using npm trusted publishing/OIDCversion.jsonbefore publishingValidation
yarn install --immutableyarn pre-compile,yarn compile, andyarn package:jsgit diff --checkCoordinated rollout
This is paired with ddoghq/serverless-ci#303, which removes the legacy Vault npm-token publication and keeps Go → PyPI → Maven → GitHub release ordering.
Before merging the pair and creating a release tag:
npm-publishGitHub environment and allow onlyv2-*tags.datadog-cdk-constructs-v2, repositoryDataDog/datadog-cdk-constructs, workflowpublish.yml, and environmentnpm-publish.Jira: SVLS-10010