project-tips: expand the data-leakage line into a concrete checklist - #712
Open
ipezygj wants to merge 1 commit into
Open
project-tips: expand the data-leakage line into a concrete checklist#712ipezygj wants to merge 1 commit into
ipezygj wants to merge 1 commit into
Conversation
The tips already said 'avoid data leakage' but gave no way to check for it. Adds the prediction-time question, the single-feature probe, and a worked example from a dataset capstone projects actually use (DataCo late delivery: ~97% with the shipping-time columns the label is computed from, ~69% with only order-time features).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
projects/project-tips.mdalready tells students to "avoid data leakage — don't include target-derived features", but gives no way to actually check for it. This expands that one line into a short, checkable list:Framing follows the course's tone: the lower, honest number is the one worth putting in the README — which is also what the rubric's "clear problem description" asks for.
(Also mentioned in a mail to Alexey on Aug 8 — this is the PR that mail promised.)