Repository navigation
feat(samples): add customer installation handoff - #724
Draft
defangdevs wants to merge 1 commit into
Draft
defangdevs wants to merge 1 commit into
defangdevs wants to merge 1 commit into
Conversation
defangdevs
had a problem deploying
to
deploy-changed-samples
September 26, 2026 03:49 — with
GitHub Actions
Failure
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
customer-handoffsample for the merged Portal create-handoff contractThis is intentionally a draft current-contract foundation. It does not present the active machine-auth/callback work in portal#1086 or lifecycle/revocation work in portal#1087 as shipped. Automatic deployment is current behavior from merged portal#1093.
Refs DefangLabs/portal#1091 and pairs with DefangLabs/defang-docs#436. Supersedes the unsafe browser-token prototype in #717.
Current contract demonstrated
createInstallationHandoffGraphQL request and initialpending/readyresponse handlinginstallationName303 See Otherto the exact returnedhandoffUrlSecurity
Screenshot
Constitution gates
Testing
npm test— 10 passednpx prettier --check portal-client.js portal-client.test.js server.js server.test.jsnode --check portal-client.js && node --check server.jsdocker compose configdefang compose configscripts/check-sample-files.shdocker compose build/healthand rendered UI smoke testRepository-level
npx eslintcannot start because this repository has noeslint.config.*; this branch adds no lint suppression. The JavaScript syntax and formatter checks above pass.Dependency before production use
Keep this PR in draft while the desired unattended integration is blocked on #1086 and #1087. The sample itself is mergeable as an honest evaluation foundation and can be updated to machine credentials/status/callbacks once those contracts merge.