Repository navigation
Conversation
CI failed on every PR because scripts/build_pyz.py was deleted while ci.yml still ran it. Smoke does not need a pyz. Restrict smoke.yml push to main so pull requests no longer run twice. Co-authored-by: Jonathan Borgwing <DevVig@users.noreply.github.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 9 minutes. View limit details
Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The review surfaced no objective defects within the changed workflow files, leaving no comments or active issues to resolve.
No open issues 🎉
What changed in this PR
This PR fixes the failing CI workflow and removes duplicate Smoke runs. The CI workflow was failing on every PR because its Build pyz step invoked scripts/build_pyz.py, which had been deleted in a prior commit. The Smoke workflow ran on both push and pull_request, duplicating runs for same-repo PR branches.
Changes:
- Remove the obsolete
Build pyzstep fromci.yml(the remaining smoke step does not need the pyz, sincea2dev_cli.pyimports the locala2apackage). - Restrict
smoke.yml'spushtrigger to themainbranch, mirroringci.yml, to eliminate duplicate PR runs.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Drops the Build pyz step that referenced the deleted scripts/build_pyz.py, fixing the red CI. |
.github/workflows/smoke.yml |
Limits the push trigger to main so each PR commit no longer runs Smoke twice. |
Review effort: Balanced
Summary
CI:.github/workflows/ci.ymlfailed on every PR atBuild pyzbecause it still ranpython3 scripts/build_pyz.pyafter that file was deleted (def8468). Recent failed runs (40796152064, 40796154114) logcan't open file '.../scripts/build_pyz.py': [Errno 2] No such file or directory. The remainingpython3 a2dev_cli.py smokestep does not need a pyz (verified locally:SMOKE PASS).Smoke:.github/workflows/smoke.ymlran on everypushand everypull_request, so each PR commit ran twice. Push is now limited tomain(same pattern asci.yml).Intentionally not changed
concurrency/cancel-in-progress: truetoci.ymlandsmoke.yml, and does not add it torelease.yml.release.yml: still callsscripts/build_pyz.pyon tag publish. Out of scope for this PR (tag-only; not the red PR CI).main, were not modified.Linked Story / Issue
Checklist
Notes
Build pyzstep and unrestrictedsmoke.ymlpush.python3 a2dev_cli.py smoke→SMOKE PASS.