Skip to content

ci: fix red CI and stop duplicate Smoke runs - #28

Open
DevVig wants to merge 1 commit into
mainfrom
ci/fix-red-ci
Open

DevVig wants to merge 1 commit into
mainfrom
ci/fix-red-ci

Conversation

@DevVig

@DevVig DevVig commented Oct 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix red CI: .github/workflows/ci.yml failed on every PR at Build pyz because it still ran python3 scripts/build_pyz.py after that file was deleted (def8468). Recent failed runs (40796152064, 40796154114) log can't open file '.../scripts/build_pyz.py': [Errno 2] No such file or directory. The remaining python3 a2dev_cli.py smoke step does not need a pyz (verified locally: SMOKE PASS).
  • Dedupe Smoke: .github/workflows/smoke.yml ran on every push and every pull_request, so each PR commit ran twice. Push is now limited to main (same pattern as ci.yml).

Intentionally not changed

Linked Story / Issue

  • Story ID(s): N/A (CI fix)

Checklist

  • No secrets added (scanned)
  • Docs updated (user/dev/ops) — not applicable
  • Rollout/rollback plan noted — revert this PR

Notes

  • Rollback: restore the Build pyz step and unrestricted smoke.yml push.
  • Local check: python3 a2dev_cli.py smoke → SMOKE PASS.
Open in Web Open in Cursor 

CI failed on every PR because scripts/build_pyz.py was deleted
while ci.yml still ran it. Smoke does not need a pyz. Restrict
smoke.yml push to main so pull requests no longer run twice.

Co-authored-by: Jonathan Borgwing <DevVig@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 29, 2026 01:36
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 101 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 5d8d3fea-5ce7-4545-a0c8-c71bf2b76dcd
Commits

Reviewing files that changed from the base of the PR and between 5fd4225 and a4f7795.

Files selected for processing: 2
  • .github/workflows/ci.yml
  • .github/workflows/smoke.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review surfaced no objective defects within the changed workflow files, leaving no comments or active issues to resolve.

No open issues 🎉

What changed in this PR

This PR fixes the failing CI workflow and removes duplicate Smoke runs. The CI workflow was failing on every PR because its Build pyz step invoked scripts/build_pyz.py, which had been deleted in a prior commit. The Smoke workflow ran on both push and pull_request, duplicating runs for same-repo PR branches.

Changes:

  • Remove the obsolete Build pyz step from ci.yml (the remaining smoke step does not need the pyz, since a2dev_cli.py imports the local a2a package).
  • Restrict smoke.yml's push trigger to the main branch, mirroring ci.yml, to eliminate duplicate PR runs.
File Description
.github/​workflows/​ci.yml Drops the Build pyz step that referenced the deleted scripts/build_pyz.py, fixing the red CI.
.github/​workflows/​smoke.yml Limits the push trigger to main so each PR commit no longer runs Smoke twice.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants