Repository navigation
Conversation
Keep the required check rust (macos-latest) reporting on every PR, but run the macos-latest cargo job only on push to main or when Rust, Tauri, or this workflow change. Co-authored-by: Jonathan Borgwing <DevVig@users.noreply.github.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 8 minutes. View limit details
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Run the expensive
macos-latestrust cargo job only on push to main or when a PR touches Rust, Tauri, or this workflow. Keep the required checkrust (macos-latest)reporting success on every other PR.Why
rust (macos-latest)is a required Protect-main check, so the matrix leg was running on every PR — including docs, adapters, and UI-only changes. Audit (section g): 0.8 min typical / 2.8 min on heavier PRs; about 5–17 macOS minutes/month in the sample (6 PR runs).How
changesjob diffs the PR against its base (alwaysmacos=trueon push to main).crates/, rootCargo.toml/Cargo.lock,rust-toolchain.toml,apps/microbridge-ui/src-tauri/,.github/workflows/ci.yml, plus.cargo//rustfmt.toml/clippy.tomlif added later.rust (ubuntu-latest)on every PR (matrix is ubuntu-only).rust (macos-latest)always runs so the required check is never skipped. It usesmacos-latestwhenchanges.macosis true; otherwise it reports success onubuntu-latestin a few seconds.A job-level
if:that skipped this job would leave the required check unreported and block merge. Step-levelifplus a conditionalruns-onkeeps the name stable.How was this tested?
rust (macos-latest)has no job-levelif; ubuntu matrix no longer includesmacos-latest.ci.yml, so CI will exercise the real macOS rust path. The skip path will show up on later docs/UI/adapter-only PRs.Savings
UI/adapter Dependabot PRs skip macOS; cargo Dependabot still runs it.
Not in this PR
Swift build & test(section g) is a different repo — not this checkout.release.yml/finalize-release.ymlmacOS jobs are release-time; they had no sample PR runs.rust (ubuntu-latest)orui(also required checks). Concurrency already landed in ci: cost hygiene (concurrency, filters, retention) #118.Checklist
mb-protocolanddocs/protocol.md