feat(cli): add MSI install scope and default it to per-user - #5799
Open
nikuda wants to merge 2 commits into
Open
feat(cli): add MSI install scope and default it to per-user#5799nikuda wants to merge 2 commits into
nikuda wants to merge 2 commits into
Conversation
Add [bundle.windows.wix] install_scope (PerUser / PerMachine). Unset matches NSIS CurrentUser: %LOCALAPPDATA%\Programs, no UAC. PerMachine remains opt-in for Program Files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSI installers from
dx bundlenow default to per-user:%LOCALAPPDATA%\Programs\<product>,InstallScope="perUser",InstallPrivileges="limited", no UAC. That matches the existing NSIS default (CurrentUser). Per-machine (ProgramFiles, elevated) is opt-in.Previously the WiX template hardcoded
InstallScope="perMachine"with no config.Config
Breaking changes
Stock
dx bundle --package-types msi(noinstall_scope) installs per-user instead of per-machine.Test plan
[bundle.windows.wix]→PerUser;install_scope = "PerMachine"→PerMachineLocalAppDataFolder\ProgramsandInstallPrivileges="limited"; per-machine keepsProgramFiles*Folder