RS-22478: fix stored XSS in palm tree tooltips - #63
Merged
Conversation
HTML-escape row/column names and label text built into tooltip content (covers both the tooltip render and its size measurement). Rebuilt the inst/htmlwidgets bundle. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JustinCCYap
reviewed
Jun 12, 2026
| <td style="text-align:right;font-family:${fontFamily};font-size:${fontSize}px">${prefix ? escapeHtml(prefix) : ''}${value || ''}${suffix ? escapeHtml(suffix) : ''}</td> | ||
| <td style="text-align:left;font-family:${fontFamily};font-size:${fontSize}px">${escapeHtml(name)}</td> | ||
| <td style="text-align:center"> | ||
| <div style="width:${barWidth}px;height:8px;background-color:${(valueEnabled) ? barColor : unselectedColor}"></div> |
Contributor
There was a problem hiding this comment.
How much validation and normalization do we do with barColor and unselectedColor? Could it be an arbitrary string (via Displayr UI)? Similarly for fontFamily.
Contributor
Author
There was a problem hiding this comment.
Thanks! Also looking to see if there are similar cases in rhtmlHeatmap and rhtmlDendrogram
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTML-escape row/column names and label text built into tooltip content (covers both the tooltip render and its size measurement).