Repository navigation
fix(web): align remote assignment table colors with datahub subject table - #1811
Conversation
gdevenyi
left a comment
There was a problem hiding this comment.
Thanks for this. Two things are missing before this can merge:
The maintainers accept the page background for tables and inputs inside the wizard and delete cards, to match the datahub subject table.
- E2E test. Every change needs an end-to-end test in
testing/. Intesting/src/specs/remote-assignments-wizard.spec.ts, load a file with more than ten columns into the wizard. Then check that the column-mapping table (bulk-column-mapping) is no taller than 28rem (448px) and that it scrolls (scrollHeight > clientHeight). The spec already has aboundingBoxhelper for this type of layout check. - Unit tests. In
apps/web/src/components/BulkRemoteAssignmentWizard/__tests__/MapStep.test.tsx, check that the column-mapping table frame gets the height cap and the vertical scroll classes. InWizardTable.test.tsx, check that the frame keepsbg-backgroundwhen a caller passes its ownclassName.
If you hand this to Claude Code, Opus 5 is the right size — the tests span apps/web and the Playwright suite, and the e2e part must load a wide fixture file through the wizard.
Reviewed at commit 7fc352c.
joshunrau
left a comment
There was a problem hiding this comment.
Thanks for adding the tests. They pin the cap and the table surface exactly as asked. Two small things before this can go in:
- Split the first commit. Commits are merged as they are, and each
fixcommit becomes one changelog entry.7fc352cincludes the column-mapping height cap (MapStep.tsx:124-125) under a subject about table colours, so the cap would never appear in the changelog. Please give the cap its own commit, e.g.fix(web): cap the column mapping table so a wide file cannot push the wizard's controls off screen. Put thebulk-column-mappingtestid move, the MapStep unit test, the e2e case and the page-object additions from22c5f85in that commit. Keep the colour changes, the checkbox column width (SourceStep.tsx:262-263) and the WizardTable test in the other commit, with a subject that also covers the width, e.g.fix(web): align remote assignment tables with the datahub subject table. Each commit should pass lint and the tests on its own. - Use the canonical Tailwind class.
mainrecently rewrote every class inapps/webto Tailwind's canonical spelling (c11dfab28). Formax-h-[28rem]that spelling ismax-h-112, which compiles to the same CSS. Please change it inapps/web/src/components/BulkRemoteAssignmentWizard/MapStep.tsx:124, and update the class the test checks in__tests__/MapStep.test.tsx:79.
If you hand this to Claude Code, Opus 5 is the right size — it is a history rewrite across apps/web and testing in which each new commit has to pass on its own.
Reviewed at commit 22c5f85.
… wizard's controls off screen A file with many columns grew the mapping grid one row per column until the step's own Back and Continue buttons sat below the fold. The frame is capped at 28rem and scrolls within itself, so the step keeps its height whatever the file is. The testid moves onto that frame, since it is the scrolling element a test has to measure.
The create and delete assignment tables overrode their row colour to the card surface, so each read as one more box inside the card rather than as the same grid the datahub shows. They now take the page background, as do the wizard's table frame, file dropzone and paste box, and the checkbox column is given the same width in both tables so the two line up.
e137f66 to
4db3225
Compare
|
Both items are in, as a rewrite onto current
The class is now Checks: |
Summary
rootStylecard-color overrides from create and delete remote assignment DataTables so their row colors match the datahub subject tablebg-backgroundto WizardTable, FileDropzone and TextArea in the bulk assignment wizard so they use the page background instead of inheriting the card surfacesize: 40, maxSize: 40) between create and delete assignment tables🤖 Generated with Claude Code