Repository navigation
Complete the truncated example in validation.properties - #925
Open
VolodymyrLinuxovich wants to merge 1 commit into
Open
VolodymyrLinuxovich wants to merge 1 commit into
VolodymyrLinuxovich wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #913
The comment at the top of validation.properties stopped in the middle of the getValidInput example. This finishes it with the catch block. It also says that setEmail gets the canonical input, and that getValidInput can throw IntrusionException for input that looks like an attack.
The same comment said patterns are prefixed with "Validation." But DefaultSecurityConfiguration looks them up as "Validator." plus the type name, and every pattern in the file uses Validator. So I fixed the prefix in the example. I also fixed a missing parenthesis and "for you needs".
The text was the same in both copies, so I changed configuration/esapi/validation.properties and src/test/resources/esapi/validation.properties. Only comments changed. ValidatorTest still passes.