Repository navigation
Conversation
* Return a fallback dummy service instead of null in `createServer` when a service is not found or not yet initialized.
* Cleanly return `{ success: false, seqNum: ... }` to the client for pre-init requests.
In `nime`'s `requestHandler.js`, `service` default destructuring does not trigger when `service` is explicitly `null`. Any request arriving before `init` previously attempted `null.textReducer()`, causing an unhandled fatal `TypeError` that crashed the entire Node server. Returning a fallback dummy service prevents the crash without modifying upstream `node_modules`.
Generated with assistance from Antigravity (Gemini 3.8 Flash)
Contributor
|
用系統 node v24 直接跑
第二個情境是 nime #946 與 #955 修的是同一條路徑,行為在這組測試裡完全一樣。 (測試腳本與本留言由 Claude Code (Claude Fable 5.1) 協助產生) |
This was referenced Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #937
Summary of Changes
{ textReducer, response }from thecreateServercallback innode/server.jswhen a service is not found or not yet initialized.{ success: false, seqNum: ... }cleanly rather than throwing a fatal error.Rationale
In
nime'srequestHandler.js,servicedefault destructuring does not trigger whenserviceis explicitlynull. Any request arriving beforeinitpreviously attemptednull.textReducer(), causing an unhandled fatalTypeErrorthat crashed the entire Node server. Returning a fallback dummy service prevents the crash without modifying upstreamnode_modules.Generated with assistance from Antigravity (Gemini 3.8 Flash)