Skip to content

fix(installer): remove obsolete VC++ redist check (#966) - #974

Open
dannyward630 wants to merge 1 commit into
EasyIME:masterfrom
dannyward630:fix/issue-966-remove-vcredist
Open

dannyward630 wants to merge 1 commit into
EasyIME:masterfrom
dannyward630:fix/issue-966-remove-vcredist

Conversation

@dannyward630

Copy link
Copy Markdown
Contributor

Closes #966.

Windows 10+ includes the Universal CRT, PIME's native binaries statically link the MSVC runtime, and embedded Python bundles vcruntime140.dll. Remove the redundant runtime download that can block offline installations.

  • Removed the ensureVCRedist call and function.
  • Removed the DownloadAndInstallVCRedist macro and its now-unused INetC plugin registration.
  • Removed the VC++ Redistributable prompts from the English, Simplified Chinese, and Traditional Chinese catalogs.

Validation:

  • Passed git diff --check.
  • Passed a focused static check for removed installer references and preserved UTF-8 BOMs.
  • Not run locally: the Windows build and NSIS compilation; makensis is unavailable on this macOS host. The PR's Windows CI will compile the installer.

Generated with assistance from Codex (GPT-6).

Windows 10 includes the Universal CRT, PIME binaries statically link the MSVC runtime, and embedded Python bundles vcruntime140.dll. Remove the redundant download that can block offline installs.

Generated with assistance from Codex (GPT-6).
@dannyward630
dannyward630 marked this pull request as ready for review October 20, 2026 07:21

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

installer: remove obsolete ensureVCRedist check and VC++ redistributable download

1 participant