Repository navigation
Conversation
The View XPub Address modal joined a wallet's xpubs into one paragraph with a single Copy button, and users could not tell a modern BTC wallet has two keys. List each key from getDisplayPublicKeys as a labeled EdgeRow copy row, matching the transaction ID card, with a primary Copy All button. The private view key modal keeps its single-key layout.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
j0ntz
added
the
awaiting-dep-publish
j0ntz
removed
the
awaiting-dep-publish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asana task
The View XPub Address modal showed a modern BTC wallet's ypub and zpub as one paragraph with a single Copy button. Support tickets showed users could not tell there were two keys or copy just one.
Each key now gets its own row in the transaction details Transaction ID style: a label, the key, and a copy icon. Tapping a row copies only that key, with no label. Labels come from the key's address format: SegWit (bip84), Wrapped SegWit (bip49), Legacy (bip44), Legacy (BIP32). The primary button reads Copy All when there is more than one key and copies the keys joined by newlines, matching the old Copy output. A single-key wallet keeps the Copy button. The explorer link uses the first key.
The keys come from the new
EdgeAccount.getDisplayPublicKeys, which falls back to the singlegetDisplayPublicKeyvalue for plugins without the tools method. The private view key option, which shared this code path, keeps its original layout.Tested on the iOS simulator with both dependency branches linked: the BTC wallet shows SegWit and Wrapped SegWit rows, a SegWit row tap leaves only the zpub on the clipboard, and Copy All leaves the zpub and ypub on two lines.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeAccount.getDisplayPublicKeys, needs a publish before CI passes)Requirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Low Risk
Wallet-menu UI and clipboard behavior only; private view key path is unchanged aside from being split into its own handler.
Overview
View XPub Address no longer dumps every display public key into one modal paragraph. The flow is split from Private View Key, which keeps the warning alert and single-key copy/link behavior.
For xpub, the app calls
getDisplayPublicKeysand renders each entry in anEdgeCardas anEdgeRowwith a human-readable label (SegWit, Wrapped SegWit, Legacy, etc.) and a per-row copy control. The modal primary action is Copy All when multiple keys exist (newline-joined, same as before); a single key still uses Copy. Block explorer still opens with the first key. New locale strings back the labels and Copy All.Reviewed by Cursor Bugbot for commit b0fcbe0. Bugbot is set up for automated code reviews on this repo. Configure here.
Test evidence
b0fcbe0Show each xpub on its own copy row
2026-10-17
1. xpub copy cards
2. segwit row copied
3. copy all copied
Awaiting publish: edge-core-js@2.53.0 (npm latest when applied: 2.52.0)