Repository navigation
Conversation
Contributor
Author
📸 Accelerate confirmation, before and after (iOS simulator)before current develop
after this branch
Captured by the agent's in-app test run (build-and-test). |
j0ntz
approved these changes
Nov 13, 2026
j0ntz
left a comment
j0ntz
left a comment
Contributor
There was a problem hiding this comment.
Reviewed at 61c47da (high): nothing blocking. The inline comments carry one warning and three suggestions.
Nit (commit-subject-50): 0a6c46c69 subject is 60 chars. Suggest Show recipient and amount when accelerating (43).
Rejected in curation (1)
src/components/modals/AccelerateTxModal.tsx:127: the target's own currency code is ignored when formatting. Rejected: accelerate is UTXO-only and every spend target pays out in the transaction's own asset, whichacceleratedTx.tokenIdalready names.
The Accelerate modal showed only the old and new fee. Acceleration rebuilds and re-signs the whole payment, so the confirmation should show everything the user is authorizing. The modal now lists the recipient address(es) and the send amount, taken from the `spendTargets` the plugin's `accelerate()` returns, and the text asks the user to review them along with the new fee. With a plugin that does not return `spendTargets` the rows are absent.
peachbits
force-pushed
the
matthew/accelerate-confirmation-details
branch
from
November 13, 2026 23:29
61c47da to
f7560ef
Compare
peachbits
force-pushed
the
matthew/accelerate-confirmation-details
branch
from
November 13, 2026 23:41
f7560ef to
aeb839e
Compare
Contributor
Author
📸 Three recipients: rows scroll, slider stays in place (iOS simulator)three recipients
three recipients scrolled
Captured by the agent's in-app test run (build-and-test). |
Contributor
Author
|
All four inline comments are addressed in fixups. The commit subject is now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matthew
Description
Asana task
The Accelerate Transaction confirmation showed only the old and new fee. Acceleration rebuilds and re-signs the whole payment, so the confirmation now shows everything the user is authorizing.
spendTargetsthat the plugin'saccelerate()returns.spendTargets, the new rows are absent and the modal looks as it did before.Testing
src/__tests__/modals/AccelerateTxModal.test.tsx: single recipient (snapshot), several recipients, a token send, and no spend targets.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-currency-plugins#467 supplies
spendTargets. This PR is safe to merge without it; the rows appear once the app picks up a plugin release that includes it.Requirements
If you have made any visual changes to the GUI. Make sure you have:
Tested on an iOS simulator (iPhone 17 Pro) only.