Repository navigation
Remove the unused Guava implementation dependency - #15
Open
jaime-jmebot wants to merge 1 commit into
Open
jaime-jmebot wants to merge 1 commit into
jaime-jmebot wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The library declares Guava 31.1-jre, but neither its production sources nor its examples use Guava. This unnecessarily adds its transitive dependencies to consumers. The declared version matches advisories for Guava temporary-file/directory helpers (CVE-2020-8908 and CVE-2023-2976); no call to those helpers was found in this project.
Change
Remove the unused implementation dependency and its generated-template comment. Keep the public Commons Math dependency and Java settings unchanged.
Validation
This reduces dependency exposure; it does not establish that an application was exploitable. Consumers using Guava directly should declare it themselves.
This automated PR is part of the jMonkeyEngine community library quality check.