elip150: add multi-key test vectors and forbid paths in blinding key - #45
Open
delta1 wants to merge 2 commits into
Open
elip150: add multi-key test vectors and forbid paths in blinding key#45delta1 wants to merge 2 commits into
delta1 wants to merge 2 commits into
Conversation
Add Valid Descriptors 11-12 covering multisig DESCRIPTOR expressions with index-derivable keys (KEY/0/* and BIP389 multipath KEY/<0;1>/*), and Invalid Descriptor 8 showing a blinding key with a derivation path is rejected. Also make explicit in the spec text that BLINDING_KEY must resolve to a single fixed key with no path component. Closes ElementsProject#34.
jgriffiths
reviewed
Aug 5, 2026
| ** Reason: single private key is WIF, not hex | ||
| * Invalid Descriptor 8 | ||
| ** <code>ct(xpub6ERApfZwUNrhLCkDtcHTcxd75RbzS1ed54G1LkBUHQVHQKqhMkhgbmJbZRkrgZw4koxb5JaHWkY4ALHY2grBGRjaDMzQLcgJvLJuZZvRcEL/0/*,elwpkh(xpub69H7F5d8KSRgmmdJg2KhpAK8SR3DjMwAdkxj3ZuxV27CprR9LgpeyGmXUbC6wb7ERfvrnKZjXoUmmDznezpbZb7ap6r1D3tgFxHmwMkQTPH))#t8tpvh0m</code> | ||
| ** Reason: blinding key expression must not contain a derivation path |
Collaborator
There was a problem hiding this comment.
please add each listed forbidden element as its own test case (and update with a valid test case assuming fixed unhardened paths are allowed).
jgriffiths
reviewed
Aug 5, 2026
| * Invalid Descriptor 8 | ||
| ** <code>ct(xpub6ERApfZwUNrhLCkDtcHTcxd75RbzS1ed54G1LkBUHQVHQKqhMkhgbmJbZRkrgZw4koxb5JaHWkY4ALHY2grBGRjaDMzQLcgJvLJuZZvRcEL/0/*,elwpkh(xpub69H7F5d8KSRgmmdJg2KhpAK8SR3DjMwAdkxj3ZuxV27CprR9LgpeyGmXUbC6wb7ERfvrnKZjXoUmmDznezpbZb7ap6r1D3tgFxHmwMkQTPH))#t8tpvh0m</code> | ||
| ** Reason: blinding key expression must not contain a derivation path | ||
| ** Reason: blinding key expression must not contain a wildcard, as it does not resolve to exactly one key |
Collaborator
There was a problem hiding this comment.
Nit: this is a hardened element 0h, and the case below is a multi-index <0;1> - you've documented as wildcard then hardened element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Valid Descriptors 11-12 covering multisig DESCRIPTOR expressions with index-derivable keys (KEY/0/* and BIP389 multipath KEY/<0;1>/*), and Invalid Descriptor 8 showing a blinding key with a derivation path is rejected. Also make explicit in the spec text that BLINDING_KEY must resolve to a single fixed key with no path component. Closes #34.