Skip to content

New appraisal approach - #1563

Draft
tsmbland wants to merge 6 commits into
single_optimisation_investmentfrom
cumulative_appraisal
Draft

tsmbland wants to merge 6 commits into
single_optimisation_investmentfrom
cumulative_appraisal

Conversation

@tsmbland

Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed (if any). Please also
include relevant motivation and context. List any dependencies that are required for
this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc
  • Update release notes for the latest release if this PR adds a new feature or fixes a bug
    present in the previous release

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@github-actions github-actions Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: 2e13b38 Previous: 6a19604 Ratio
example_run/missing_commodity example 380511431 ns 271642953 ns 1.40
example_run/simple example 347399804.5 ns 101135279 ns 3.44
example_run/two_regions example 1004184981 ns 641326530 ns 1.57
select_best_assets_sequential/15 171565421 ns 131658938.5 ns 1.30

This comment was automatically generated by workflow using github-action-benchmark.

@tsmbland
tsmbland force-pushed the cumulative_appraisal branch from 2e13b38 to e123241 Compare November 4, 2026 10:43
@tsmbland
tsmbland changed the base branch from main to circularity_milp November 4, 2026 10:44
@tsmbland
tsmbland force-pushed the cumulative_appraisal branch from e123241 to 1b07beb Compare November 4, 2026 14:31
@tsmbland
tsmbland changed the base branch from circularity_milp to single_optimisation_investment November 4, 2026 14:31

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant