Skip to content

re-enable the fitted step 3 acceptance test - #151

Merged
kriboe90 merged 1 commit into
masterfrom
develop_enable_fitted_step_3_acceptance_test
Oct 27, 2026
Merged

kriboe90 merged 1 commit into
masterfrom
develop_enable_fitted_step_3_acceptance_test

Conversation

@kriboe90

Copy link
Copy Markdown
Contributor

Step Three With Fit has been commented out since the fitted step 3 output was written without a delimiter between the main and the fit columns (#136). Both parts of that fix are on master, so the case runs again and the fitted path of step 3 stays covered.

Verification

Full acceptance suite on adc5c2c (current master, so including the side band pedestal columns of #145 and #150, which take the fitted row from 20 to 23 fields): 27 tests, 27 passed, 0 failed, Step Three With Fit among them. The fitted case costs about 41 s of the 216 s total, since it runs 400 fits over the four synthetic images.

Scope of the re-enabled case

It asserts Directory Should Not Be Empty, so it covers the fitted path against a crash, not against a wrong column layout. The layout itself is covered by TestColumnNames in ledsa/tests/UnitTests/test_background_subtraction.py and by Fitted Step 3 Output Can Be Analysed in 08_test_background_subtraction.robot.

Two things found while verifying, not addressed here

  • is_tqdm_output in LedsaATestLibrary.py treats any stderr containing Processing images as progress-bar noise. Since -s3 prints its progress bar to stderr, a traceback raised during image processing is discarded, and the test then fails on a vague directory does not exist instead of the real error. check_error_msg also reacts with a bare exit(), which ends the run as "Execution stopped by user" rather than as failed tests.
  • ${WORKDIR} is ${TEMPDIR}/ledsa for every run, so two concurrent runs of the suite on one machine delete each other's working directory.

🤖 Generated with Claude Code

Step Three With Fit has been commented out since the fitted step 3 output was
written without a delimiter between the main and the fit columns (#136). Both
parts of that fix are on master, so the case runs again and keeps the fitted
path of step 3 covered.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@kriboe90
kriboe90 merged commit 29018c3 into master Oct 27, 2026
5 checks passed
@kriboe90
kriboe90 deleted the develop_enable_fitted_step_3_acceptance_test branch October 27, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant