Repository navigation
re-enable the fitted step 3 acceptance test - #151
Merged
Merged
Conversation
Step Three With Fit has been commented out since the fitted step 3 output was written without a delimiter between the main and the fit columns (#136). Both parts of that fix are on master, so the case runs again and keeps the fitted path of step 3 covered. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step Three With Fithas been commented out since the fitted step 3 output was written without a delimiter between the main and the fit columns (#136). Both parts of that fix are on master, so the case runs again and the fitted path of step 3 stays covered.Verification
Full acceptance suite on
adc5c2c(current master, so including the side band pedestal columns of #145 and #150, which take the fitted row from 20 to 23 fields): 27 tests, 27 passed, 0 failed,Step Three With Fitamong them. The fitted case costs about 41 s of the 216 s total, since it runs 400 fits over the four synthetic images.Scope of the re-enabled case
It asserts
Directory Should Not Be Empty, so it covers the fitted path against a crash, not against a wrong column layout. The layout itself is covered byTestColumnNamesinledsa/tests/UnitTests/test_background_subtraction.pyand byFitted Step 3 Output Can Be Analysedin08_test_background_subtraction.robot.Two things found while verifying, not addressed here
is_tqdm_outputinLedsaATestLibrary.pytreats any stderr containingProcessing imagesas progress-bar noise. Since-s3prints its progress bar to stderr, a traceback raised during image processing is discarded, and the test then fails on a vaguedirectory does not existinstead of the real error.check_error_msgalso reacts with a bareexit(), which ends the run as "Execution stopped by user" rather than as failed tests.${WORKDIR}is${TEMPDIR}/ledsafor every run, so two concurrent runs of the suite on one machine delete each other's working directory.🤖 Generated with Claude Code