Repository navigation
test: open boundaries with DB and one namelist per line in the test inputs - #151
Merged
Merged
Conversation
…nputs slcf_masks.fds and slcf_partial.fds had `&VENT MB='XMIN' ... / &VENT MB='XMAX' ... /` on one line; FDS reads only the first namelist of a line, so the +x boundary was never open. With several meshes, MB also applies the vent to the faces of every mesh rather than the domain (FDS User Guide), as in wall_005.fds with its 24 meshes, where FDS then wrote boundary data on the faces between meshes. All three now use DB, one vent per line; trailing whitespace in wall_005.fds is removed. slcf_masks and slcf_partial are rerun with FDS 6.11.1; the obstruction mask tests, including the comparisons with Smokeview, pass unchanged, as the masks depend on the geometry only. The boundary example is rerun as well; its plots are unchanged, and the notebook no longer mentions the faces between meshes. The stored FDS 6.8 output in bndf_data is kept as it is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three FDS inputs opened their boundaries in a way that did not do what was meant:
slcf_masks.fdsandslcf_partial.fdshad&VENT MB='XMIN' ... / &VENT MB='XMAX' ... /on one line. FDS reads only the first namelist of a line, so the +x boundary was never open.MBapplies the vent to the faces of every mesh, not to the domain (see the FDS User Guide onMBandDB). Inwall_005.fds(24 meshes via&MULT) FDS therefore wrote boundary data on the faces between meshes, holding only the ambient temperature.All three inputs now use
DBwith one vent per line.Checks
slcf_masksandslcf_partialare rerun with FDS 6.11.1. All tests pass unchanged, including the obstruction mask tests compared with Smokeview: the masks depend on the geometry only.wall_005) is rerun with FDS 6.11.1; its plots are unchanged, and the faces between meshes are gone. The notebook text about these data is updated.tests/cases/bndf_datais kept as it is.🤖 Generated with Claude Code