Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

fix: flowise-766 - #6709

Merged
0xi4o merged 1 commit into
mainfrom
fix/flowise-766
Aug 7, 2026
Merged

fix: flowise-766#6709
0xi4o merged 1 commit into
mainfrom
fix/flowise-766

Conversation

@0xi4o

@0xi4o 0xi4o commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@0xi4o
0xi4o merged commit f20d094 into main Aug 7, 2026
7 checks passed
@0xi4o
0xi4o deleted the fix/flowise-766 branch August 7, 2026 05:07
dblagbro added a commit to dblagbro/flow-wiser that referenced this pull request Aug 12, 2026
Upstream merged FlowiseAI#6680, FlowiseAI#6708 and FlowiseAI#6709 on 2026-08-07 -- after the announced code
freeze and after the 2026-08-05 archive snapshot. All three are maintainer-authored
bug fixes to code this fork shares, and none were present here.

Merged with a merge commit, not squashed, so the three commits keep Ilango
Rajagopal as their author. Squashing would have collapsed them into a single
commit authored by the merger, and his name would have survived only as prose in
a message -- invisible to git blame, the contributor graph, and every tool that
answers "who wrote this". docs/backlog.md BL-03 puts it directly: a contribution
merged without its author's name is a contribution stolen.

The licence check that mattered: all three imported their permission middleware
from packages/server/src/enterprise/rbac/PermissionCheck, which carries
FlowiseAI's Commercial License and does not exist in this tree. apache2-only had
zero enterprise/ imports before this branch. The final commit repoints them at
identity/rbac/PermissionCheck and is kept separate, so the upstream work stays
untouched and the adaptation is visibly ours.

Worth recording: the pre-adoption check verified which files each patch MODIFIES
and reported clean. It did not check what the added lines IMPORT. A patch can
leave every licensed file untouched and still make the tree depend on one.

Permission tokens were verified against identity/rbac/Permissions.ts before
adopting -- chatflows:view, chatflows:update, documentStores:view and
documentStores:upsert-config all resolve. The catalog is deny-by-default, so an
unrecognised token would not have failed the build; it would have silently denied
every request to those routes.

CI green: guard, build (ubuntu-latest, 22.23.2), build.
dblagbro added a commit to dblagbro/flow-wiser that referenced this pull request Aug 12, 2026
…ill merging (#18)

The 2026-08-05 snapshot was taken because "upstream repository moves to public
archive on 2026-08-10, which locks issues and pull requests". That did not
happen. Verified 2026-08-12: archived=false, disabled=false, comments still
working, and three pull requests merged on 2026-08-07 -- after the documented
2026-07-29 code freeze and after the snapshot was taken.

Upstream is frozen, not closed. Contributions can still be commented on and, on
this evidence, still merged.

This contradicts docs/PROJECT-LOG.md, docs/product.md and docs/STATUS.md, which
all assert the archive happened. It also makes a public comment on upstream
FlowiseAI#6706 wrong. Both are flagged in DELTA-2026-08-12.md rather than corrected here,
because the licensing narrative is REVIEW REQUIRED and belongs to a human.

Synced:
  * 3 new PRs captured as git am-able patches -- FlowiseAI#6714, FlowiseAI#6723, FlowiseAI#6725
  * 3 upstream-MERGED fixes this fork does not have, captured to
    merged-after-snapshot/ -- FlowiseAI#6680, FlowiseAI#6708, FlowiseAI#6709, all maintainer-authored
  * prs/index.json refreshed 347 -> 346, issues 698 -> 701
  * both indexes normalised to a single JSON array; the originals were 11
    concatenated per-page arrays that parse only with jq -s. Data was complete
    in both, only the shape changed.

Licence check applied to all six new patches: no diff hunks against
packages/server/src/enterprise/ or IdentityManager.ts. All clean, no stripping
required, and no hunk content was read to determine it -- decisions made on the
diff --git path headers alone, per docs/CLEANROOM-PROTOCOL.md.

DELTA-2026-08-12.md also records where Flow-Wiser has already solved a still-open
upstream PR, with the fork's fix being the more complete one in every confirmed
case: FlowiseAI#6670 and FlowiseAI#6642 (the unpinned Docker version -- this fork's founding
defect, still open upstream from two independent reporters), FlowiseAI#6706
(connect-sqlite3), and FlowiseAI#4805 (Node 22, open since 2025-07-06 for the change
ADR-0004 completed this week across ten locations rather than three).

Contributing any of it back is an outward action and is left for authorization.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants