Skip to content

ci: add MacOS build - #4152

Open
victorapm wants to merge 30 commits into
developfrom
ci/paludettomag1/macos
Open

ci: add MacOS build#4152
victorapm wants to merge 30 commits into
developfrom
ci/paludettomag1/macos

Conversation

@victorapm

@victorapm victorapm commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@victorapm victorapm self-assigned this Sep 24, 2026
@victorapm victorapm added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Sep 24, 2026
@victorapm victorapm added the flag: no rebaseline Does not require rebaseline label Sep 24, 2026
@victorapm victorapm added the ci: run code coverage enables running of the code coverage CI jobs label Sep 24, 2026
@victorapm victorapm added the ci: run device builds Allows to run the device (CUDA/HIP) builds label Sep 24, 2026
@victorapm

victorapm commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

@rrsettgast @joshua-white @OmarDuran @tjb-ltk and any other mac users: this is ready for review

@victorapm

victorapm commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

pinging @MelReyCG , @OmarDuran , @bd713 , @corbett5 , @dkachuma , @herve-gross , @jhuang2601 for a code owner review 🙏

MelReyCG
MelReyCG approved these changes Oct 20, 2026
View reviewed changes

@MelReyCG MelReyCG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me, just a few minor suggestions:

  • No unit-test for this system? Is it for performance or are there some that do not pass?

  • maybe consider to add plain script files rathen than directly writing them in the run : Load TPL image & Build GEOS are quite long, and Load TPL image even have a subscript (scripts/macos_loadTPL.sh/scripts/macos_build.sh?).

@victorapm

victorapm commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

@MelReyCG Thanks! We'll keep macOS job build-only for now and defer unit tests (it takes too long to run). I've addressed your second point in cf95733

@MelReyCG

MelReyCG commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

PR waiting for last testings, waiting updates from @victorapm / @joshua-white

@joshua-white

joshua-white commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Looks good to me. Let me know if I need to help with anything.

@victorapm

victorapm commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, Josh! Could you launch the LC install with the TPL branch? Thanks!

OmarDuran
OmarDuran approved these changes Oct 30, 2026
View reviewed changes

@OmarDuran OmarDuran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you @victorapm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OmarDuran OmarDuran OmarDuran approved these changes
@joshua-white joshua-white joshua-white approved these changes
@herve-gross herve-gross herve-gross approved these changes
@jhuang2601 jhuang2601 jhuang2601 approved these changes
@bd713 bd713 bd713 approved these changes
@MelReyCG MelReyCG MelReyCG approved these changes
@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner
@dkachuma dkachuma Awaiting requested review from dkachuma dkachuma is a code owner
@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner
@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner

Assignees

@victorapm victorapm

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run device builds Allows to run the device (CUDA/HIP) builds ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review flag: requires updated TPL(s) Needs a specific TPL PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reintroduce MacOS CI using GitHub M1 runners

7 participants

@victorapm @MelReyCG @joshua-white @OmarDuran @herve-gross @jhuang2601 @bd713