Repository navigation
refactor: avoid non-primitive values in ternary branches - #573
Merged
Merged
Conversation
Replace the ternaries flagged by local/ternary-primitive-only with if statements and small helpers, keeping the evaluation order. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
JulienChampagnol
force-pushed
the
feat/ternary_primitive_only
branch
from
November 3, 2026 11:20
69e4674 to
80fe3db
Compare
JulienChampagnol
changed the title
BotellaA
approved these changes
Nov 3, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e_only # Conflicts: # app/components/Viewer/Generic/Model/ModelEdgesCard.vue # app/components/Viewer/Generic/Model/ModelPointsCard.vue
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
local/ternary-primitive-onlyoxlint rule reports (if/else, early returns, small helpers), keeping the evaluation order and laziness of each branch.Rollout
The oxlint config and plugin are not part of this PR: they reach the repo through the prepare workflow once actions#93 is merged. This branch is already clean for that rule (0 violations).
Test plan
oxlintwith the new rule: 0 violations; no other lint finding added compared tonext🤖 Generated with Claude Code