General update and product rename - #193
Conversation
caitlinadams
left a comment
caitlinadams
left a comment
There was a problem hiding this comment.
This largely looks good to me, I made a few minor requests for clarity, but happy for you to address them as you see fit.
| returned from the ASF API is different than that returned from the CDSE API | ||
| returned from the ASF API is different than that returned from the CDSE API. | ||
|
|
||
| Warning - Only IW Bursts Available |
There was a problem hiding this comment.
I'm not sure I entirely understand this comment -- are you saying that ASF only has IW bursts (and not EW bursts), or are you saying that ASF only has IW in bursts (not scenes). Will a warning be triggered if the user tries to look for EW bursts?
There was a problem hiding this comment.
Added some clearer comments
| ) | ||
| from sar_pipeline.analysis.compare_cog import compare_cog_stats | ||
|
|
||
| VALID_SENSOR_MODES = ["IW"] |
There was a problem hiding this comment.
Is the plan to update this when EW is supported? Or is IW the only valid sensor mode?
There was a problem hiding this comment.
If plan is to update, it might be worth adding a "TODO" comment
There was a problem hiding this comment.
Yep thats planned in another PR, will add a TODO
| # make the base .yaml for RTC processing | ||
| if product == "RTC_S1": | ||
| RTC_RUN_CONFIG = RTCConfigManager(base_config="S1_RTC.yaml") | ||
| RTC_RUN_CONFIG = RTCConfigManager(base_config=f"S1_RTC_{sensor_mode}.yaml") |
There was a problem hiding this comment.
You don't have a failure mode if that config file doesn't exist -- should you add one in case they're deleted or someone tries to use their own config file? Or are these scenarios unlikely to come up?
There was a problem hiding this comment.
This does get handles in the RTCConfigManager if it's not a valid BaseConfigType -
caitlinadams
left a comment
caitlinadams
left a comment
There was a problem hiding this comment.
Looks good, thanks for making the minor changes
2 participants
ga_s1a_nrb_0-1-0_...->ga_s1a_nrb_iw_0-1-0_)--platform linux/amd64to all docker commands. Ensures build and run on other platforms (e.g. mac os / arm)