You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Move search, members and unread counts to the v2 endpoints - #6829
/sync and the /connect warm-up move to a new SyncApi that stays on v1: /sync returns events in the socket's encoding, so it moves together with the socket.
Testing
V2LaneBatchSixTest parses the v2 search, members and unread responses and checks the request payloads.
MoshiChatApiTest covers the calls routed through SyncApi.
Summary by CodeRabbit
Bug Fixes
Improved compatibility for search, member, and unread-count requests with the updated chat API.
Preserved connection warm-up and sync-history functionality while keeping those requests on the appropriate API version.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
📝 Walkthrough
GeneralApi now uses v2 chat paths for search, members, and unread requests. A new SyncApi defines the v1 warm-up and sync-history endpoints. ChatModule registers both interfaces with their corresponding Retrofit builders, and MoshiChatApi uses SyncApi for those calls. Tests cover the updated sync API wiring and v2 parsing and serialization.
Priority: ⬇️ Low
Merge Risk:⚪ Minimal · up to dc94f
The new endpoint paths resolve as intended under the standard configuration. No actionable issue remains before normal merge checks.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 24 functions across 6 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly and concisely identifies the main change: moving search, members, and unread counts to v2 endpoints.
Description check
The description includes the goal, implementation, testing, and linked issue. It is mostly complete, but it omits the required Checklist section and its issue, tests/docs, and CLA items.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the routes with care, V2 paths hop through open air. SyncApi keeps the warm-up neat, And history finds its v1 beat. The tests tuck custom data in, Then nibble carrots with a grin.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Move message search, member queries and unread counts to the v2 endpoints. The websocket stays on v1.
Part of AND-1637
Implementation
GeneralApiis built on/api/v2/chat/..../syncand the/connectwarm-up move to a newSyncApithat stays on v1:/syncreturns events in the socket's encoding, so it moves together with the socket.Testing
V2LaneBatchSixTestparses the v2 search, members and unread responses and checks the request payloads.MoshiChatApiTestcovers the calls routed throughSyncApi.Summary by CodeRabbit