Keep the websocket connected when an event fails to parse after connecting

[gpunto]

Goal

A websocket event that fails to parse made the client disconnect, reconnect and sync. When the same malformed event kept coming, the connection looped through reconnects. Drop and log such an event instead, as iOS does.

Closes AND-1660

Implementation

• Once the connection event has been parsed, a frame that fails to parse and isn't an error is logged at error level (its event type and the parse error, never its content) and dropped. The connection stays up.
• Before the connection, such a frame still fails the connect. Error frames are handled as before.
• A dropped event's update is lost until the next sync.

Testing

• StreamWebSocketTest covers a frame that fails to parse after connecting (dropped, the next event is delivered) and an error frame after connecting (still delivered). The existing case for a frame that fails before connecting is unchanged.

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of malformed real-time events: after connection, unrecognized events are ignored so they don’t prevent subsequent valid events from being delivered.
  • Server error events continue to be reported, including after connection.

[github-actions]

PR checklist ✅

All required conditions are satisfied:

• Title length is OK (or ignored by label).
• At least one pr: label exists.
• Sections ### Goal, ### Implementation, and ### Testing are filled, or the PR is bot-authored.
• An issue is linked (Linear ticket or GitHub issue), or the PR is bot-authored.

🎉 Great job! This PR is ready for review.

[github-actions]

SDK Size Comparison 📏

SDK	Before	After	Difference	Status
stream-chat-android-client	6.21 MB	6.21 MB	0.00 MB	🟢
stream-chat-android-ui-components	11.52 MB	11.52 MB	0.00 MB	🟢
stream-chat-android-compose	13.18 MB	13.19 MB	0.00 MB	🟢
stream-chat-android-ai-compose	2.04 MB	2.04 MB	0.00 MB	🟢
stream-chat-android-ai-ondevice	1.67 MB	1.67 MB	0.00 MB	🟢

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: b015bc32-c266-4ab9-92b0-387bf0419c48

📥 Commits

Reviewing files that changed from the base of the PR and between baa9870 and 3cc4d47.

📒 Files selected for processing: 2

• stream-chat-android-client/src/main/java/io/getstream/chat/android/client/socket/StreamWebSocket.kt
• stream-chat-android-client/src/test/java/io/getstream/chat/android/client/socket/experimental/ws/StreamWebSocketTest.kt

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

StreamWebSocket now tracks whether it has received a ConnectedEvent. It emits recognized socket errors when parsing fails. Before connection, other parse failures produce CANT_PARSE_EVENT. After connection, those malformed frames are logged and dropped. The message callback emits only non-null parse results. New tests cover malformed and recognized error events after connection.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 3cc4d

The change is ready to merge after normal checks. No issue was found that would prevent malformed frames from being dropped while the connection continues.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 18.18% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description check		The description includes the required Goal, Implementation, and Testing sections. It explains the behavior before and after connection, error handling, logging, dropped updates, linked issue, and test…
Title check		The title clearly and concisely describes the main change: keeping the websocket connected when an event fails to parse after connection.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit taps the socket frame,
ConnectedEvent marks the state by name.
A known error hops into the stream,
A bad frame after connection leaves unseen.
The next good event arrives on cue,
The rabbit thumps: “The tests came through!”}

_{Comment @coderabbitai help to get the list of available commands.}

[aleksandar-apostolov]

LGTM

[stream-public-bot]

🚀 Available in v7.15.0