Repository navigation
build: replace nginx runtime with a pinned node static server - #46
Merged
Merged
Conversation
Serve the static export from node:24.22.3-alpine3.24 with a dependency-free server that keeps the raw Markdown, retired route, and 404 contracts. Pin oven/bun 1.4.4 for the builder and CI.
Normalize request paths before routing, never look outside the root for /, add ETag/Last-Modified revalidation, and bound shutdown. CI now builds the image, runs scripts/smokeImage.sh, and fails on fixable High/Critical CVEs.
vigneshrajsb
marked this pull request as ready for review
November 18, 2026 20:36
vmelikyan
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reader and task
Source of truth
oven/bun:1.4.4-alpineandnode:24.22.3-alpine3.24, both pinned by digest./, a raw.mdroute, a missing.md,/docs/cm*, an unknown route, a missing asset, the non-root user, and a cleanSIGTERMexit.Documentation changes
server.mjskeeps the nginx behavior:.htmlbefore a same-name directory, SPA fallback toindex.html,404.htmlfor misses, and 404 for the retired/docs/cmroutes..mdis served astext/markdown; charset=utf-8and a missing file returns 404. The regex check ondefault.confis replaced bytests/server.test.ts, which tests the same contracts against the running server.public or non-sensitive references (keep private identifiers in task scratch): N/A, no external state.
Other changes:
8080as thenodeuser, socontainerPortand probes move to8080. The service port stays80.apk upgradeand removes npm, npx, corepack, and yarn. A Grype scan shows no fixable CVEs. The remaining findings are OpenSSL 3.5.9 and busybox advisories with no fixed release yet.1.4.4to match the image.bun install --frozen-lockfilepasses with the current lockfile.imageCI job builds the Dockerfile, runsscripts/smokeImage.shagainst the container (routing contract, non-root user, cleanSIGTERMexit), and fails on High/Critical CVEs that have a fixed release./docs//cmand encoded..cannot bypass the retired-route 404 or leave the root. It also sendsETagandLast-Modifiedand answers revalidation with304, as nginx did.Verification
.agents/skills/update-lifecycle-docs/references/ste100-review.mdbun run check:stylesbun run check:rawbun run verifybun run check:contracts --require-allwhen schema, API, or CLI claims changedbun run check:screenshotswhen visuals changed