Repository navigation
Backport FaceLayer Rendering System to 1.20.1 - #5574
Open
Ghostipedia wants to merge 15 commits into
Open
Ghostipedia wants to merge 15 commits into
Ghostipedia wants to merge 15 commits into
Conversation
(cherry pick 5370 and 5376 and resolve conflicts, this does NOT compile rn)
Member
Author
|
Will be working on this over the next few days/weeks/whenever I have the time. |
… from dying, need someone more experienced to look at this
… into gp/1.20/cherry/render-nightmare
Ghostipedia
marked this pull request as ready for review
October 23, 2026 06:31
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This is a cherry-pick and then adaptation of all cumulative render fixes/changes that culminated in #5370 and then #5376
See PR description, it's a long one, but the goal of this PR was to backport it.
Implementation Details
This was done by first cherrypicking the relevant PRs down to 1.20, checking what was there, different, was strictly a bad cherrypick, etc. and then a few commits focused on removal/adaption/migration.
FaceLayer has been properly implemented as well, works as expected
AI Usage
Yes, Codex 6.1 Sol on medium
Used to compare the render backends of 1.20 and 1.21 and note what should/shouldn't be kept. I'm pretty familiar with these as well so this was mostly used for migration/automation/verification.
Outcome
Both 1.20 and 1.21 have visually consistent render behaviors. Pipes still have some rendering issues, but I will be fixing that on 1.20 and 1.21 in a seperate PR, as I do not want to overscope this PR to start fixing every small issue I find on 1.20 compared to 1.20
How Was This Tested
Eyeballs, lots of eyeballs, renderdoc captures, and generally verifying the same way the original PR was handled
Potential Compatibility Issues
Uh, as stated with the last one
FaceLayer docs will not be included with this PR until the pipe related fixes are done for 1.20 and 1.21, as they may need adaptations that would constantly block this PR. hence why they are still not done.