Skip to content

Fix get-demos CI: remove module.exports incompatible with Node 24 #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SeiferTim merged 2 commits into from
Jul 3, 2026
Merged

Fix get-demos CI: remove module.exports incompatible with Node 24 #386

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02ef320
Initial plan
Copilot Jul 3, 2026
f214731
Fix get-demos job: remove module.exports wrapper incompatible with No…
Copilot Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 19 additions & 22 deletions .github/workflows/build-concurrently.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,35 +39,32 @@ jobs:
// of paths
// note: actions/github-script will encode the result
// in JSON! we decode it later

const fs = require('fs');
const path = require('path');

module.exports = ({core}) => {
try {
let projectPaths = [];
try {
let projectPaths = [];

function findProjectXmlFiles(dir) {
const filesAndDirs = fs.readdirSync(dir, {withFileTypes: true});

function findProjectXmlFiles(dir) {
const filesAndDirs = fs.readdirSync(dir, {withFileTypes: true});
for (const item of filesAndDirs) {
const fullPath = path.join(dir, item.name);
if (item.isDirectory())
findProjectXmlFiles(fullPath);
else if (item.isFile() && item.name.match(/project.xml/i))
projectPaths.push(dir);
}
}

for (const item of filesAndDirs) {
const fullPath = path.join(dir, item.name);
if (item.isDirectory())
findProjectXmlFiles(fullPath);
else if (item.isFile() && item.name.match(/project.xml/i))
projectPaths.push(dir);

}
}
findProjectXmlFiles("./");

findProjectXmlFiles("./");
console.log(projectPaths);

console.log(projectPaths);

return projectPaths;
} catch (error) {
core.setFailed(error.message);
}
return projectPaths;
} catch (error) {
core.setFailed(error.message);
}


Expand Down
Loading