Repository navigation
[cppia] Upgrade sljit - #1434
Merged
Merged
Conversation
See: zherczeg/sljit@04c7fcc SLJIT_FUNC is empty, but the sljit tutorials still use it so let's keep it.
It was added so that cppia functions use the abi expected by sljit, in: 21a2194 sljit no longer uses fastcall on x86-32. See: zherczeg/sljit@a6c8e5b It is still set to empty, because it is set in haxe generated code and this way it matches SLJIT_FUNC
It looks like now sJitTemp0 can get overwritten during the conversion,
making the multiplication produce the wrong value. This caused a
regression:
results: SOME TESTS FAILURES (success: false)
cases.TestCommon
testStatus: FAILURE F
line: 34, expected "ok" but it is "Failed regression test for HaxeFoundation#926. x: 9"
tobil4sk
force-pushed
the
upgrade-sljit
branch
from
October 29, 2026 10:36
f365a87 to
9321303
Compare
Member
|
Let's do this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades sljit to zherczeg/sljit@39c508d.
This seems to get the haxe cppia jit unit tests passing on linux arm64, at least through qemu. Hopefully, it will also fix the random mac arm64 failures that have been seen there.
We had some in-tree patches applied. I have reapplied: b220c1d, since the issue still remains. The remaining ones I have omitted intentionally:
Perhaps we might want to consider merging this after #1399/#1400 to have more confidence that the arm jit is all good.