Repository navigation
fix(gui): drop deleted apps from the start menu (#4228) - #4243
Open
kunaaaalcodes wants to merge 1 commit into
Open
kunaaaalcodes wants to merge 1 commit into
kunaaaalcodes wants to merge 1 commit into
Conversation
The start menu read a session-cached launch-apps list and only refetched when it was empty, so an app deleted after page load (for example in Dev Center) stayed in Recent and Recommended until a reload. Refetch on every open, and filter out entries the backend marks unlaunchable, so a reclaimed or inaccessible app leaves the list too. Apply the same filter to the dashboard's Recent apps. Adds helpers/launchAppsList.js with filterLaunchableApps and its unit test.
kunaaaalcodes
force-pushed
the
fix/4228-devcenter-app-startmenu
branch
from
October 14, 2026 17:36
2bf5eea to
8e9dc46
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An app deleted after the desktop has loaded stays visible in the start menu's
Recent and Recommended lists, and in the dashboard's recently-used grid,
until the page is reloaded. The start menu renders from a session-cached
window.launch_appslist that only refreshed when its recent list was alreadyempty, so a deletion that happens later in the same session never reaches the
desktop.
What changed
GET /get-launch-apps?icon_size=64every time itopens, not only when the cached recent list is empty. This matches the existing
pattern in
TabHome.loadRecentApps, which already always refetches.src/gui/src/helpers/launchAppsList.jswithfilterLaunchableApps(apps),a pure helper that drops entries the backend marks unlaunchable
(
privateAccess.hasAccess === false) and nullish entries.A deleted app is simply absent from the fresh response, so the refetch is what
removes it. The filter additionally covers apps that stay in the list but cannot
launch, such as a reclaimed hosting, where the backend nulls
index_urland setsprivateAccess.hasAccesstofalse.Files changed
src/gui/src/helpers/launchAppsList.jsfilterLaunchableApps.src/gui/src/helpers/launchAppsList.test.jssrc/gui/src/UI/UITaskbar.jssrc/gui/src/UI/Dashboard/TabHome.jsbuildRecentAppsHTMLrenders from the filtered list and shows the empty state when every recent entry is filtered out.No backend change:
/get-launch-appsalready excludes deleted apps, and thedelete path already tombstones the store and cache.
Testing
npm test -- src/helpers/launchAppsList.test.jsinsrc/gui→6 passed.npm testinsrc/gui→918 passed | 10 skipped, with 2failures that are pre-existing and unrelated (they fail identically with these
changes stashed):
src/UI/Dashboard/TabTeams.render.test.js(an i18n stringexpectation) and
src/services/pdfThumbnails/browser.test.js(suite-level).node --checkpasses on all four files.Manual verification
npm start, sign in athttp://puter.localhost:4100.start menu.
dashboard's recently-used grid.
get-launch-apps), a fresh request fires on eachstart-menu open.
Notes
marks unlaunchable are filtered.
menu still renders.
Fixes Deleting a Custom Dev Centre app doesn't remove it from the start menu #4228