Skip to content

postgresql@18: add stop_timeout 120 - #295196

Merged
BrewTestBot merged 2 commits into
Homebrew:mainfrom
IngmarStein:postgresql-stop-timeout
Jul 28, 2026
Merged

postgresql@18: add stop_timeout 120#295196
BrewTestBot merged 2 commits into
Homebrew:mainfrom
IngmarStein:postgresql-stop-timeout

Conversation

@IngmarStein

@IngmarStein IngmarStein commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?
  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

AI-assisted contribution by Claude Code (Opus 5) of ~5% of the work. Validation steps done by AI: brew audit --strict pass, brew style pass.

Adds stop_timeout 120 to the service block to gracefully shut down
PostgreSQL before launchd escalates to a forced kill. When PostgreSQL is
killed abruptly, it leaves behind postmaster.pid and lock files in the
data directory, requiring manual cleanup.

Uses stop_timeout from Homebrew/brew#23294 (released in https://github.com/Homebrew/brew/releases/tag/6.0.13).

@github-actions github-actions Bot added perl Perl use is a significant feature of the PR or issue formula deprecated Formula deprecated formula disabled Formula disabled icu4c ICU use is a significant feature of the PR or issue labels Jul 25, 2026
@IngmarStein
IngmarStein marked this pull request as draft July 25, 2026 12:06
@github-actions github-actions Bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 27, 2026
@IngmarStein
IngmarStein force-pushed the postgresql-stop-timeout branch from 3c8b6f3 to 8d2cf7e Compare July 27, 2026 22:23
@github-actions github-actions Bot removed automerge-skip `brew pr-automerge` will skip this pull request formula disabled Formula disabled labels Jul 27, 2026
@IngmarStein
IngmarStein marked this pull request as ready for review July 27, 2026 22:25
iMichka
iMichka approved these changes Jul 28, 2026
View reviewed changes

@iMichka iMichka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

馃 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

鈿狅笍 Bottle publish failed.

@IngmarStein @iMichka
postgresql@18: add stop_timeout 120
06f5a5b 
When PostgreSQL is killed abruptly (SIGKILL), it leaves behind postmaster.pid
and lock files in the data directory, preventing a subsequent start until those
files are manually removed. A 120-second graceful stop timeout allows PostgreSQL
to shut down cleanly before launchd escalates to a forced kill.
@iMichka
iMichka force-pushed the postgresql-stop-timeout branch from 8d2cf7e to 06f5a5b Compare July 28, 2026 19:14
@iMichka

iMichka commented Jul 28, 2026

Copy link
Copy Markdown
Member

Rebased on main

@github-actions github-actions Bot added the formula disabled Formula disabled label Jul 28, 2026
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

馃 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 28, 2026
@BrewTestBot
BrewTestBot enabled auto-merge July 28, 2026 20:42
@BrewTestBot
BrewTestBot added this pull request to the merge queue Jul 28, 2026
Merged via the queue into Homebrew:main with commit 8416063 Jul 28, 2026
19 checks passed
@iMichka

iMichka commented Jul 28, 2026

Copy link
Copy Markdown
Member

@IngmarStein are you adding this to the other PostgreSQL versions or should we do it?

@IngmarStein

IngmarStein commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@iMichka I'm currently traveling and would appreciate if you could apply this to the other formulae. Otherwise, I can take this on in around two weeks.

@IngmarStein
IngmarStein deleted the postgresql-stop-timeout branch July 29, 2026 19:44
This was referenced Jul 29, 2026
Merged
Merged
This was referenced Jul 29, 2026
Merged
Merged
@iMichka

iMichka commented Jul 29, 2026

Copy link
Copy Markdown
Member

Done for all versions up to version 14.
Version 13 and 12 are disabled and will be removed soon

pull Bot pushed a commit to cyberchen1995/homebrew-core that referenced this pull request Jul 29, 2026
@iMichka
postgresql@16: add stop timeout
0d52b86 
Follow up from Homebrew#295196
pull Bot pushed a commit to cyberchen1995/homebrew-core that referenced this pull request Jul 29, 2026
@iMichka
postgresql@15: add stop timeout
f2ef5ea 
Follow up from Homebrew#295196
pull Bot pushed a commit to cyberchen1995/homebrew-core that referenced this pull request Jul 29, 2026
@iMichka
postgresql@14: add stop timeout
13660f9 
Follow up from Homebrew#295196
botantony pushed a commit that referenced this pull request Jul 29, 2026
@iMichka @botantony
postgresql@17: add stop timeout
24b808a 
Follow up from #295196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iMichka iMichka iMichka approved these changes
@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. formula deprecated Formula deprecated formula disabled Formula disabled icu4c ICU use is a significant feature of the PR or issue perl Perl use is a significant feature of the PR or issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IngmarStein @iMichka @BrewTestBot