Skip to content

fix(observability): skip OTLP-JSON exporter tests without the otel extra #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhati27 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(observability): skip OTLP-JSON exporter tests without the otel extra #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/observability/tests/test_file_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import json
from pathlib import Path

import pytest
from opentelemetry import trace
from opentelemetry.sdk.resources import Resource
from opentelemetry.sdk.trace import TracerProvider
Expand All @@ -14,6 +15,9 @@
from observability import runspan as _runspan
from observability.file_exporter import OTLPJsonFileExporter

# Encoding needs protobuf and the OTLP encoder, both from the "otel" group.
_OTLP_ENCODER = "opentelemetry.exporter.otlp.proto.common._internal.trace_encoder"


def _reset_provider():
"""Swap in a fresh global TracerProvider for the next test."""
Expand All @@ -32,6 +36,7 @@ def _install_file_exporter(path: Path) -> TracerProvider:


def test_file_exporter_writes_jsonl(tmp_path: Path):
pytest.importorskip(_OTLP_ENCODER)
out = tmp_path / "traces.jsonl"
_install_file_exporter(out)

Expand Down Expand Up @@ -64,6 +69,7 @@ def test_file_exporter_creates_parent_dir(tmp_path: Path):


def test_file_exporter_appends(tmp_path: Path):
pytest.importorskip(_OTLP_ENCODER)
out = tmp_path / "traces.jsonl"
_install_file_exporter(out)

Expand Down