Fix double bracket indexing bug on Hermes noise model - #786
Open
atvasilopoulos wants to merge 1 commit into
Open
Fix double bracket indexing bug on Hermes noise model#786atvasilopoulos wants to merge 1 commit into
atvasilopoulos wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Double brackets were used to index a torch tensor in the hermes noise model, leading to a UserWarning when using it. Fixed this by changing it to proper indexing.
Details
The following warning was raised when using the hermes noise model (
model.program_analog_weights()).Found 5 instances where this indexing pattern was used in the class. Single bracket solves the issue.