default value related issues - #228
Open
gabrielssanches wants to merge 8 commits into
Open
Conversation
This was introduced in 65ba86f and it breaks applications where the configuration file has a pdo entry for the cia402 control word but the command_interface is not defined
…value' default is used in the single pdo interface, might as well use it here for consistency
…he drive is initialized
gabrielssanches
force-pushed
the
fix-cia402-default-value
branch
from
June 29, 2026 07:49
90c6743 to
a712717
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are commits related to how the default value is handled
Additionally, there is a commit for cia402 driver that reverts the initialized check to what is was before 65ba86f
and a commit making 'addr_offset' mandatory for groupped PDOs as it does not make sense to have groupped PDOs without offset.
I can split into 3 PR's if that makes sense, let me know
note: this PR is locally build on top of #182