Skip to content

E02: FlatFile separator bug - #245

Merged
jacobdenobel merged 5 commits into
masterfrom
wp/E02-flatfile-separator
Nov 6, 2026
Merged

jacobdenobel merged 5 commits into
masterfrom
wp/E02-flatfile-separator

Conversation

@jacobdenobel

Copy link
Copy Markdown
Contributor

Work package E02: FlatFile separator bug

Branch: wp/E02-flatfile-separator
Status: ready for review

Done

  • step 1: failing tests (meta data on: run and first property glued, e.g. "01"; meta data off passes) in tests/cpp/logger/test_flatfile.cpp
  • step 3 (review): CRLF restored in flatfile.hpp, changelog entry moved to Unreleased, iohinspector sentence removed.
  • step 2: cache_meta_data() now ends with sep_ (include/ioh/logger/flatfile.hpp); CHANGELOG.md entry under 0.4.0 / Fixed; Python test in tests/python/test_logger.py checks field counts (not run: no built ioh module here). test_flatfile: 4 tests pass (Debug build).

Next step

None. Controller turns this file into the PR body.

Decisions

  • Test target: test_flatfile (cmake -DIOH_TEST_PER_FILE=ON -DCMAKE_BUILD_TYPE=Debug), build dir build-e02 (excluded via .git/info/exclude). Run: build-e02/tests/test_flatfile Warning ".*" 99999 (the arguments are needed). Release (NDEBUG) builds crash in SetUp (clutchlog no-op logger() returns nothing, a separate pre-existing issue, not fixed here).

  • Submodules fmt and googletest were initialised in the worktree (git submodule update --init).

  • The changelog entry does not mention iohinspector; add the cross-reference ("iohinspector's reader flags these files") once that reader ships.

Open questions / Blocked

  • none
  • Other variants checked: no meta data (empty titles) was correct; store_positions was correct (sep before x columns); header is correct. Nothing else in the repo parses FlatFile output.
  • Same bug exists in all earlier versions (cache_meta_data unchanged since the logger was added).

Work package from the IOHanalyzer rebuild plan (plan/ in IOHprofiler/ioh-web). Review and merge are done by a person.

🤖 Generated with Claude Code

jacobdenobel and others added 5 commits November 5, 2026 17:47
…ata and properties

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ile rows

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ased

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lose

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@jacobdenobel
jacobdenobel marked this pull request as ready for review November 6, 2026 11:26
@jacobdenobel
jacobdenobel merged commit 9e008d2 into master Nov 6, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant