Repository navigation
E02: FlatFile separator bug - #245
Merged
Merged
Conversation
…ata and properties Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ile rows Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ased Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lose Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jacobdenobel
marked this pull request as ready for review
November 6, 2026 11:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work package E02: FlatFile separator bug
Branch: wp/E02-flatfile-separator
Status: ready for review
Done
cache_meta_data()now ends withsep_(include/ioh/logger/flatfile.hpp); CHANGELOG.md entry under 0.4.0 / Fixed; Python test in tests/python/test_logger.py checks field counts (not run: no built ioh module here).test_flatfile: 4 tests pass (Debug build).Next step
None. Controller turns this file into the PR body.
Decisions
Test target:
test_flatfile(cmake -DIOH_TEST_PER_FILE=ON -DCMAKE_BUILD_TYPE=Debug), build dirbuild-e02(excluded via .git/info/exclude). Run:build-e02/tests/test_flatfile Warning ".*" 99999(the arguments are needed). Release (NDEBUG) builds crash in SetUp (clutchlog no-oplogger()returns nothing, a separate pre-existing issue, not fixed here).Submodules fmt and googletest were initialised in the worktree (
git submodule update --init).The changelog entry does not mention iohinspector; add the cross-reference ("iohinspector's reader flags these files") once that reader ships.
Open questions / Blocked
Work package from the IOHanalyzer rebuild plan (
plan/in IOHprofiler/ioh-web). Review and merge are done by a person.🤖 Generated with Claude Code