Repository navigation
E05: Full-precision output - #247
Merged
Merged
Conversation
…ded in the JSON metadata Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… (Windows) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work package E05: Full-precision output
Branch: wp/E05-full-precision
Status: ready for review
Done
FlatFile::set_full_precision(bool)(also on Analyzer), writing{:.17g}for properties with the default double format and for x positions; JSON metadata key"precision": "%.17g"; testsflatfile_full_precision,analyzer_full_precisionin tests/cpp/logger/test_flatfile.cppfull_precision(read/write) on FlatFile and Analyzer, stubs, teststest_full_precisionandtest_flatfile_full_precisionin tests/python/test_logger.py (15 passed, run from a temp dir against.venvbuild)## UnreleasedNext step
Nothing; review and merge (E02 and E03 also add
## Unreleasedto CHANGELOG.md: expected conflict).Decisions
{:.10f}in this package. The option is off by default.{:d}, user formats) keep it. Python subclasses overridingcall_to_stringare bypassed for default-format properties when the option is on (FlatFile reads the value throughoperator())..infofiles (v1 analyzer) still use{:g}for best y; not changed."precision": "%.17g"is written only with the option on. Absence means the legacy%.10f. Old readers ignore unknown keys.full_precision_initialiser in flatfile.hpp to true (and keep the setter for opting out), in a release that announces it in the changelog, once iohinspector and IOHanalyzer readers are known to read the longer values. Then also write the"precision"key always ("%.10f"for the legacy mode).Open questions / Blocked
Work package from the IOHanalyzer rebuild plan (
plan/in IOHprofiler/ioh-web). Review and merge are done by a person.🤖 Generated with Claude Code